New issue
Advanced search Search tips

Issue 900835 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Abrt in sk_abort_no_print

Project Member Reported by ClusterFuzz, Nov 1

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5130425255854080

Fuzzer: libFuzzer_transfer_cache_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x05390019d173
Crash State:
  sk_abort_no_print
  SkColorSpaceXformSteps::SkColorSpaceXformSteps
  SkColorSpaceXformSteps::SkColorSpaceXformSteps
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=595362:595363

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5130425255854080

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 1

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 1

Cc: enne@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Nov 1

Labels: Test-Predator-Auto-Owner
Owner: mtkl...@google.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://skia.googlesource.com/skia/+/cfa315390f04ebcdfac3569758535aec9f63dc0c (update SkColorSpace APIs and members).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: brianosman@google.com
Labels: -Pri-1 Pri-3
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/fed7ec30cc71ab71cab71649545b2212c85f1c71

commit fed7ec30cc71ab71cab71649545b2212c85f1c71
Author: Mike Klein <mtklein@google.com>
Date: Thu Nov 01 16:38:19 2018

test for hash collision with memcmp

The hash is computed byte-wise, so we should compare byte-wise.

As written, if the two matrices are the same but contain a NaN,
they'll fail the comparison test, but should pass.

Bug:  chromium:900835 
Change-Id: I2fcef309ed604c8c1e03e268252778e7bd6d27a1
Reviewed-on: https://skia-review.googlesource.com/c/167263
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/fed7ec30cc71ab71cab71649545b2212c85f1c71/src/core/SkColorSpaceXformSteps.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83e4c2cff160ca1d074076deb8535ca09a244fc0

commit 83e4c2cff160ca1d074076deb8535ca09a244fc0
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Nov 01 18:34:02 2018

Roll src/third_party/skia fa7df23d8b0c..460a43deb18f (6 commits)

https://skia.googlesource.com/skia.git/+log/fa7df23d8b0c..460a43deb18f


git log fa7df23d8b0c..460a43deb18f --date=short --no-merges --format='%ad %ae %s'
2018-11-01 herb@google.com Remove the unused buffers for unique glyph handling
2018-11-01 halcanary@google.com tools/skqp/make_universal_apk -> python
2018-11-01 mtklein@google.com test for hash collision with memcmp
2018-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 1ce6da5c8d99..26679709b32f (1 commits)
2018-11-01 herb@google.com Reland "Move from a functional to object based interface between Painter and SkDraw"
2018-11-01 caryclark@skia.org update bookmaker build docs


Created with:
  gclient setdep -r src/third_party/skia@460a43deb18f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG= chromium:900835 
TBR=herb@chromium.org

Change-Id: I5ebde540f95053b8135a2ccaace218c1348882e0
Reviewed-on: https://chromium-review.googlesource.com/c/1313030
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604648}
[modify] https://crrev.com/83e4c2cff160ca1d074076deb8535ca09a244fc0/DEPS

Project Member

Comment 8 by ClusterFuzz, Nov 2

ClusterFuzz has detected this issue as fixed in range 604647:604648.

Detailed report: https://clusterfuzz.com/testcase?key=5130425255854080

Fuzzer: libFuzzer_transfer_cache_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x05390019d173
Crash State:
  sk_abort_no_print
  SkColorSpaceXformSteps::SkColorSpaceXformSteps
  SkColorSpaceXformSteps::SkColorSpaceXformSteps
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=595362:595363
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=604647:604648

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5130425255854080

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Nov 2

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5130425255854080 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment