Some ResourceLoad slices in trace don't have BEGINs. |
||
Issue descriptionWhat steps will reproduce the problem? (1) Start recording a trace with disabled-by-default-network (2) Open a tab and navigate to a docs page (I used https://docs.google.com/document/d/1GvzDP-tTLmJ0myRhUAfTYWs3ZUFilUICg8psNHyccwQ) (3) Stop recording the trace What is the expected result? All slices for ResourceLoad have BEGIN. What happens instead? Some slices don't have BEGIN. See attached trace and screenshot.
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a9b490fcde2aaeab4956c59ea4de84c826f151b commit 1a9b490fcde2aaeab4956c59ea4de84c826f151b Author: Kenichi Ishibashi <bashi@chromium.org> Date: Thu Nov 01 09:35:29 2018 Don't record end mark of traces for loading resource too early Before this CL, we called ResourceLoadContinuesBeyondScope() only after StartLoad() succeeded. This wasn't enough to cover all loading cases and ResourceLoader::DidFinishLoading() could be called when we already record END marks for tracing. This CL changes to call ResourceLoadContinuesBeyondScope() when resource still needs loading or is loading. Bug: 900815 Change-Id: I478e1e36c41b0fdc50f43c7d99687ea615eaaf2a Reviewed-on: https://chromium-review.googlesource.com/c/1312174 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604543} [modify] https://crrev.com/1a9b490fcde2aaeab4956c59ea4de84c826f151b/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
,
Nov 2
|
||
►
Sign in to add a comment |
||
Comment 1 by hc70...@gmail.com
, Nov 1