New issue
Advanced search Search tips

Issue 900809 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

autofill_phone_number_i18n_fuzzer does not start

Project Member Reported by och...@chromium.org, Nov 1

Issue description

https://clusterfuzz.com/v2/performance-report/libFuzzer_autofill_phone_number_i18n_fuzzer/libfuzzer_chrome_asan/2018-10-28

It looks like the dictionary format is broken:

Bot: clusterfuzz-linux-pre-5zn1
Time ran: 0.085203

ParseDictionaryFile: error in line 1
		"-"


 
This one starts fine for me?

$ gn gen out/libfuzzer '--args=use_libfuzzer=true is_asan=true is_debug=false is_component_build=true' --check
$ autoninja -C out/libfuzzer/ autofill_phone_number_i18n_fuzzer
$ out/libfuzzer/autofill_phone_number_i18n_fuzzer 

Gives a working fuzzer.
Cc: mpdenton@chromium.org
Sure, the fuzzer binary may run, but if you add `-dict=` argument pointing to https://cs.chromium.org/chromium/src/components/autofill/core/browser/BUILD.gn?q=autofill_phone_number_i18n_fuzzer&sq=package:chromium&g=0&l=638, I suspect it will exit out with an error mentioned in c#0.
Ah I see, for some reason I figured the dictionary was hardcoded into the binary.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05841f7edd071665edf4c796cd8e9ad77e63fa6b

commit 05841f7edd071665edf4c796cd8e9ad77e63fa6b
Author: Matthew Denton <mpdenton@chromium.org>
Date: Fri Nov 02 10:17:09 2018

Updated phone_number_i18n_fuzzer.dict to use hex encoding

Preventing autofill_phone_number_i18n_fuzzer from crashing on startup
due to the malformed dictionary.

BUG= 900809 

Change-Id: I0f62807cd08875e5ff29c231e71bb02b4044dffc
Reviewed-on: https://chromium-review.googlesource.com/c/1313875
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604878}
[modify] https://crrev.com/05841f7edd071665edf4c796cd8e9ad77e63fa6b/components/autofill/core/browser/phone_number_i18n_fuzzer.dict

Cc: -mpdenton@chromium.org
Owner: mpdenton@chromium.org
Status: Started (was: Untriaged)
Status: Fixed (was: Started)
Thanks, Matthew!

Sign in to add a comment