New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 900799 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Disabling multidevice feature suite installs messages PWA

Project Member Reported by azeemarshad@chromium.org, Nov 1

Issue description

Steps to reproduce:

1) Go through multidevice setup.
2) Uninstall PWA manually from the app drawer.
3) Disable multidevice feature suite.

This unexpectedly installs the PWA again.
 
Labels: OS-Chrome
Owner: azeemarshad@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6

commit 5a34aedfa81ccc128d16a34600f0003ae9f3a1a6
Author: Azeem Arshad <azeemarshad@chromium.org>
Date: Thu Nov 08 03:32:13 2018

[Multidevice] Add default-to-persist cookie logic in PWA installation

This CL adds logic to set a default-to-persist cookie that will force
the messages PWA to default to persisting the pairing. Also fixes issue
with PWA installing unexpectedly when disabling features.

Bug:  896057 , 900799 
Change-Id: I77354ecbbccf69e1b9a97e1bcff82bccaeeb44b1
Reviewed-on: https://chromium-review.googlesource.com/c/1312305
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606319}
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.h
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl_unittest.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chrome/browser/ui/webui/settings/chromeos/multidevice_handler.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/android_sms_app_installing_status_observer.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/android_sms_app_installing_status_observer.h
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/android_sms_app_installing_status_observer_unittest.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/feature_state_manager_impl.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/feature_state_manager_impl_unittest.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/public/cpp/android_sms_app_helper_delegate.h
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/public/cpp/fake_android_sms_app_helper_delegate.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/public/cpp/fake_android_sms_app_helper_delegate.h

Status: Fixed (was: Assigned)

Sign in to add a comment