Regression: The WebView in FAR OOBE screen does not show anything |
|||||||||||||
Issue descriptionChrome Version: ToT OS: ChromeOS What steps will reproduce the problem? (1) Go through the "Add person" flow (2) In the "Install apps from your other devices" screen, no app is shown in the WebView What is the expected result? Some apps should be shown in the WebView. What happens instead? Nothing is shown in the WebView. NOTE: 1. This issue is not reproducible on the build 72.0.3593.0 (ChromeOS build: 11215.0.0) 2. It seems to be a rendering issue for the WebView. On ToT, no element is found under the WebView <body> tag. But it works fine on the build 72.0.3593.0.
,
Nov 1
This likely means you are loading stuff via data:// URIs, but have unencoded '#' symbols which are now being interpreted properly and thus mark the end of content (early than you expect!). Where is the HTML/CSS/etc source for these views, and how are they loaded?
,
Nov 1
They are loaded via data URI. I believe it's the CSS file that contains the '#' symbols: https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.css
,
Nov 1
Yep, so the necessary fix is to properly encode things before loading them as data URIs. I'm aware that this is quite annoying as a legitimately Chrome-only page, but Chrome not matching the data URI spec causes web compat problems in the wider web :(.
,
Nov 1
Good to know. Thank you for the comment! Do you know if your changes will be merged to M71?
,
Nov 1
The change will not be merged into M71. Note that encoding '#' properly (as %23) is safe to do so before or after this change, so even if you want to change it and then merge that change into 71 (for whatever reason, e.g. to fix some other bug) that would be safe.
,
Nov 1
Thanks for letting me know. I asked because I was wondering if it is necessary to merge my fix into M71, say if you merge yours, then I would have to :)
,
Nov 5
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbfb76fef49dad0c84c9af106faa97cd8201973c commit bbfb76fef49dad0c84c9af106faa97cd8201973c Author: Yue Cen <rsgingerrs@chromium.org> Date: Wed Nov 07 23:28:56 2018 Fast app reinstall: Encode the data URI contents This is required after the change in https://chromium-review.googlesource.com/c/1297172 Bug: 900793 Change-Id: I6f21fefc9d24f7209e7cfc8569c009c27a90c236 Reviewed-on: https://chromium-review.googlesource.com/c/1315968 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#606203} [modify] https://crrev.com/bbfb76fef49dad0c84c9af106faa97cd8201973c/chrome/browser/resources/chromeos/login/screen_recommend_apps.js
,
Nov 8
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by rsgingerrs@chromium.org
, Nov 1Cc: rsgingerrs@chromium.org
Owner: smcgruer@chromium.org
Status: Assigned (was: Untriaged)