New issue
Advanced search Search tips

Issue 900785 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

macOS 10.14+ Dark Mode: Use dark scrollbars when using macOS Dark Mode

Project Member Reported by meh...@chromium.org, Oct 31

Issue description

Chrome Version: 72.0.3596.0 (Official Build) canary (64-bit)
OS: macOS 10.14.1

What steps will reproduce the problem?
(1) Use macOS Dark Mode

What is the expected result?
Scrollbars could be dark when we implement Dark Mode for Chrome later with issue 850098.

What happens instead?
Scrollbars are bright.

I posted this also to Webkit. Not sure if this will be won't-fix. May be we can orient us at Webkit's decision?

Thanks :)
 
Labels: Hotlist-DesktopUIConsider
Cc: markchang@chromium.org
WDYT, markchang@?

My understanding is that scrollbars are a Scary Haunted Graveyard from an eng. perspective, but this sounds good from a product perspective.
This could be blocked on moving the Blink scrollbars over to use the Views scrollbars, since we'll likely want the ones in Views controls to support dark mode as well.
Labels: Group-Dark_Mode
Fyi: My reported Webkit issue has been commented, that it is fixed in the public beta of 10.14.2. The issue has been merged into https://bugs.webkit.org/show_bug.cgi?id=190937. 

Maybe the patch from https://bugs.webkit.org/show_bug.cgi?id=190937 can help for a Chrome implementation?
Labels: M-72 Target-72
Owner: lgrey@chromium.org
Status: Assigned (was: Untriaged)
Routing to lgrey for initial assessment.
Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged
Cc: bokan@chromium.org
Components: Blink>Scroll
The Dark Scrollbars are now available in Safari 12.0.2 and macOS 10.14.2.

The Dark Scrollbars also work in System Non-DarkMode, when the website has a dark background (e.g. theverge.com). Maybe we can also support it then in System Non-DarkMode? Any chance to implement the Webkit patch mentioned c#6 in Blink? Many thanks in advance.
Bildschirmfoto 2018-12-10 um 18.48.18.png
403 KB View Download
Unless someone from Blink picks this up, I wouldn't expect it to be in the first version of Dark Mode we ship. The Webkit patch assumes a couple of things that aren't true for us right now (AFAIK):
- You can determine with a single call whether a web document has a dark appearance
- Scrollbars draw correctly if you set the appearance correctly
Labels: -M-72 -Target-72 M-73 Target-73

Sign in to add a comment