[AF Android] Footer is missing a divider on Legacy Android |
||||||
Issue descriptionThe Refresh dropdown has a single divider, separating the list view and the footer. This is not appearing on Android <N (see also: https://bugs.chromium.org/p/chromium/issues/detail?id=896339).
,
Nov 6
This was verified in Canary. Requesting merge to M71. Rationale: This fixes a user-facing (UI) glitch that was newly introduced. The CL with the fix is very low-risk as a merge; it adds a View via a trivial new XML file, and makes a small code change to wrap one existing View with the new View. It should not affect behavior or performance, and should not conflict with any other ongoing work.
,
Nov 6
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 8
Approved for merge to 71, branch 3578.
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d737cdb8080df377fe0d2ebd9ac89cbb8245c65 commit 5d737cdb8080df377fe0d2ebd9ac89cbb8245c65 Author: Tommy Martino <tmartino@chromium.org> Date: Thu Nov 08 22:34:25 2018 [AF Android] Draw divider on legacy Android The JellyBean implementation of the dropdown class doesn't show a divider between the ListView and the footer. This CL corrects that issue by wrapping the footer view in a simple new layout containing a divider, on Jellybean only. Bug: 900781 Change-Id: I37ed28c705dcfc4c0caa3aa9bde4dc122f29e9ca Reviewed-on: https://chromium-review.googlesource.com/c/1311938 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604594}(cherry picked from commit 73fac10675497af49ab57c4300239090bcb5b4e5) Reviewed-on: https://chromium-review.googlesource.com/c/1327530 Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#590} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [add] https://crrev.com/5d737cdb8080df377fe0d2ebd9ac89cbb8245c65/ui/android/java/res/layout/dropdown_footer_wrapper_jellybean.xml [modify] https://crrev.com/5d737cdb8080df377fe0d2ebd9ac89cbb8245c65/ui/android/java/src/org/chromium/ui/DropdownPopupWindowJellyBean.java
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d737cdb8080df377fe0d2ebd9ac89cbb8245c65 Commit: 5d737cdb8080df377fe0d2ebd9ac89cbb8245c65 Author: tmartino@chromium.org Commiter: tmartino@chromium.org Date: 2018-11-08 22:34:25 +0000 UTC [AF Android] Draw divider on legacy Android The JellyBean implementation of the dropdown class doesn't show a divider between the ListView and the footer. This CL corrects that issue by wrapping the footer view in a simple new layout containing a divider, on Jellybean only. Bug: 900781 Change-Id: I37ed28c705dcfc4c0caa3aa9bde4dc122f29e9ca Reviewed-on: https://chromium-review.googlesource.com/c/1311938 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604594}(cherry picked from commit 73fac10675497af49ab57c4300239090bcb5b4e5) Reviewed-on: https://chromium-review.googlesource.com/c/1327530 Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#590} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Nov 1