New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 900764 link

Starred by 1 user
Status: Verified
Owner:
█ jmgao@google.com
Last visit 26 days ago
Closed: Nov 1
Cc:
rsesek@chromium.org
█ roc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

ScopedGenericTest.Receive based_unittest's are failing on Win,win64, Mac64 and Linux64 official.desktop.continuous builders.

Project Member Reported by pbommana@google.com, Oct 31 
Link to builders :
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/44458
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20trunk/builds/17949
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20trunk/builds/13426
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/96146


Error log :
https://logs.chromium.org/logs/chrome/bb/official.desktop.continuous/win_trunk/96143/+/recipes/steps/base_unittests/0/logs/ScopedGenericTest.Receive/0

Error :
ScopedGenericTest.Receive (run #1):
[ RUN      ] ScopedGenericTest.Receive
../../base/scoped_generic_unittest.cc(171): error: Death test: a.reset()
    Result: died but not with expected error.
  Expected: destroyed with active receiver
Actual msg:
[  DEATH   ] [41908:16444:1031/134527.681:11949083:WARNING:test_suite.cc(257)] Test launcher output path C:\Users\CHROME~1\AppData\Local\Temp\36192_17645\test_results.xml exists. Not adding test launcher result printer.
[  DEATH   ] Received fatal exception EXCEPTION_BREAKPOINT
[  DEATH   ] Backtrace:
[  DEATH   ] 	std::default_delete<base::ScopedGeneric<int,base::(anonymous namespace)::IntTraits> >::operator() [0x000000014010EE37+55] (C:\b\c\b\win_trunk\src\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\VC\Tools\MSVC\14.14.26428\include\memory:2056)
[  DEATH   ] 	base::ScopedGenericTest_Receive_Test::TestBody [0x000000014010B7E7+999] (C:\b\c\b\win_trunk\src\base\scoped_generic_unittest.cc:171)
[  DEATH   ] 	testing::Test::Run [0x0000000140455E47+199] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:2529)
[  DEATH   ] 	testing::TestInfo::Run [0x0000000140456759+217] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:2702)
[  DEATH   ] 	testing::TestCase::Run [0x0000000140456CA2+258] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:2815)
[  DEATH   ] 	testing::internal::UnitTestImpl::RunAllTests [0x000000014045E43E+638] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:5181)
[  DEATH   ] 	testing::UnitTest::Run [0x000000014045E105+165] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:4791)
[  DEATH   ] 	base::TestSuite::Run [0x00000001406B6D06+118] (C:\b\c\b\win_trunk\src\base\test\test_suite.cc:294)
[  DEATH   ] 	base::`anonymous namespace'::LaunchUnitTestsInternal [0x00000001406B7C89+329] (C:\b\c\b\win_trunk\src\base\test\launcher\unit_test_launcher.cc:225)
[  DEATH   ] 	base::LaunchUnitTests [0x00000001406B7B0F+159] (C:\b\c\b\win_trunk\src\base\test\launcher\unit_test_launcher.cc:575)
[  DEATH   ] 	main [0x00000001406B6BE6+150] (C:\b\c\b\win_trunk\src\base\test\run_all_base_unittests.cc:12)
[  DEATH   ] 	__scrt_common_main_seh [0x00000001406CA9A8+268] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
[  DEATH   ] 	BaseThreadInitThunk [0x00000000779059CD+13]
[  DEATH   ] 	RtlUserThreadStart [0x0000000077B3A561+33]
[  DEATH   ]
Stack trace:
Backtrace:
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x0000000140450BF7+87] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:846)
	testing::internal::AssertHelper::operator= [0x000000014045077E+78] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:417)
	base::ScopedGenericTest_Receive_Test::TestBody [0x000000014010B870+1136] (C:\b\c\b\win_trunk\src\base\scoped_generic_unittest.cc:171)

../../base/scoped_generic_unittest.cc(172): error: Death test: ScopedInt::Receiver(*a).get()
    Result: died but not with expected error.
  Expected: existing Receiver
Actual msg:
[  DEATH   ] [20184:1912:1031/134528.548:11949941:WARNING:test_suite.cc(257)] Test launcher output path C:\Users\CHROME~1\AppData\Local\Temp\36192_17645\test_results.xml exists. Not adding test launcher result printer.
[  DEATH   ] Received fatal exception EXCEPTION_BREAKPOINT
[  DEATH   ] Backtrace:
[  DEATH   ] 	base::ScopedGenericTest_Receive_Test::TestBody [0x000000014010BA5C+1628] (C:\b\c\b\win_trunk\src\base\scoped_generic_unittest.cc:175)
[  DEATH   ] 	testing::Test::Run [0x0000000140455E47+199] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:2529)
[  DEATH   ] 	testing::TestInfo::Run [0x0000000140456759+217] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:2702)
[  DEATH   ] 	testing::TestCase::Run [0x0000000140456CA2+258] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:2815)
[  DEATH   ] 	testing::internal::UnitTestImpl::RunAllTests [0x000000014045E43E+638] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:5181)
[  DEATH   ] 	testing::UnitTest::Run [0x000000014045E105+165] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:4791)
[  DEATH   ] 	base::TestSuite::Run [0x00000001406B6D06+118] (C:\b\c\b\win_trunk\src\base\test\test_suite.cc:294)
[  DEATH   ] 	base::`anonymous namespace'::LaunchUnitTestsInternal [0x00000001406B7C89+329] (C:\b\c\b\win_trunk\src\base\test\launcher\unit_test_launcher.cc:225)
[  DEATH   ] 	base::LaunchUnitTests [0x00000001406B7B0F+159] (C:\b\c\b\win_trunk\src\base\test\launcher\unit_test_launcher.cc:575)
[  DEATH   ] 	main [0x00000001406B6BE6+150] (C:\b\c\b\win_trunk\src\base\test\run_all_base_unittests.cc:12)
[  DEATH   ] 	__scrt_common_main_seh [0x00000001406CA9A8+268] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
[  DEATH   ] 	BaseThreadInitThunk [0x00000000779059CD+13]
[  DEATH   ] 	RtlUserThreadStart [0x0000000077B3A561+33]
[  DEATH   ]
Stack trace:
Backtrace:
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x0000000140450BF7+87] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:846)
	testing::internal::AssertHelper::operator= [0x000000014045077E+78] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:417)
	base::ScopedGenericTest_Receive_Test::TestBody [0x000000014010B9DC+1500] (C:\b\c\b\win_trunk\src\base\scoped_generic_unittest.cc:172)

[  FAILED  ] ScopedGenericTest.Receive (1320 ms)



Suspecting CL : https://chromium.googlesource.com/chromium/src/+/00ce84541f824dbf1ae1860193415227254dba07

Comment 1 by jmgao@google.com, Oct 31 

Grepped around for EXPECT_DEATH and came across this, which is presumably the problem:

#ifdef OFFICIAL_BUILD
  // The official build does not print the reason a CHECK failed.
  const char kErrorRegex[] = "";
#else

Comment 2 by jmgao@google.com, Nov 1

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3ad105d163b34997853ba6fcea0eb18476b003a

commit b3ad105d163b34997853ba6fcea0eb18476b003a
Author: Josh Gao <jmgao@google.com>
Date: Thu Nov 01 01:01:57 2018

ScopedGeneric: delete regex in death tests.

The official builds apparently doesn't print the error message from
CHECK failure, so delete the death test regexes. While we're at it,
switch from the ifdef to EXPECT_DEATH_IF_SUPPORTED.

TBR=dcheng@chromium.org

Bug:  900764 
Change-Id: I61448b5fcb903b35a4cc01e0eb599ba35be1d402
Reviewed-on: https://chromium-review.googlesource.com/c/1311838
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Josh Gao <jmgao@google.com>
Cr-Commit-Position: refs/heads/master@{#604468}
[modify] https://crrev.com/b3ad105d163b34997853ba6fcea0eb18476b003a/base/scoped_generic_unittest.cc

Comment 4 by pbommana@google.com, Nov 5

Status: Verified (was: Fixed)
These test's are no longer failing on official.desktop.continuous Win,Win64,Mac64 and Linux64 builders, hence marking the bug as verified.
►

Sign in to add a comment