New issue
Advanced search Search tips

Issue 900756 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 845079



Sign in to add a comment

IME switcher in Android doesn't work

Project Member Reported by yhanada@chromium.org, Oct 31

Issue description

What steps will reproduce the problem?
(1) Install Gboard from PlayStore
(2) Open it by focusing some test field
(3) Long-press the globe icon
(4) Select input method from the pop-up dialog.

What is the expected result?
Active IME in Chrome OS switched to the selected one

What happens instead?
It doesn't.

 
Blocking: 845079
Components: Platform>Apps>ARC
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c509ea6b33ff5f43ff476e223cffa337db0eb4f

commit 0c509ea6b33ff5f43ff476e223cffa337db0eb4f
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Thu Nov 01 00:35:39 2018

Implement OnActiveImeChanged.

When active IME is changed in Android side, the event is sent to
OnActiveImeChanged().
ArcInputMethodManagerService should switch an active IME in Chrome OS
side according to the event.

Bug:  900756 
Test: Ran on DUT.
Change-Id: Ia8002ec678775f6349020b90766423987a4f714b
Reviewed-on: https://chromium-review.googlesource.com/c/1311853
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604463}
[modify] https://crrev.com/0c509ea6b33ff5f43ff476e223cffa337db0eb4f/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service.cc
[modify] https://crrev.com/0c509ea6b33ff5f43ff476e223cffa337db0eb4f/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service_unittest.cc

Labels: Merge-Request-71
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 2

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Merge approved for ChromeOS M71
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 5

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8674b27e0a064f9b619ffaa092cfaa6cacad096

commit d8674b27e0a064f9b619ffaa092cfaa6cacad096
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Mon Nov 05 19:02:06 2018

Implement OnActiveImeChanged.

When active IME is changed in Android side, the event is sent to
OnActiveImeChanged().
ArcInputMethodManagerService should switch an active IME in Chrome OS
side according to the event.

Bug:  900756 
Test: Ran on DUT.
Change-Id: Ia8002ec678775f6349020b90766423987a4f714b
Reviewed-on: https://chromium-review.googlesource.com/c/1311853
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#604463}(cherry picked from commit 0c509ea6b33ff5f43ff476e223cffa337db0eb4f)
Reviewed-on: https://chromium-review.googlesource.com/c/1318381
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#504}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/d8674b27e0a064f9b619ffaa092cfaa6cacad096/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service.cc
[modify] https://crrev.com/d8674b27e0a064f9b619ffaa092cfaa6cacad096/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service_unittest.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/d8674b27e0a064f9b619ffaa092cfaa6cacad096

Commit: d8674b27e0a064f9b619ffaa092cfaa6cacad096
Author: yhanada@chromium.org
Commiter: yhanada@chromium.org
Date: 2018-11-05 19:02:06 +0000 UTC

Implement OnActiveImeChanged.

When active IME is changed in Android side, the event is sent to
OnActiveImeChanged().
ArcInputMethodManagerService should switch an active IME in Chrome OS
side according to the event.

Bug:  900756 
Test: Ran on DUT.
Change-Id: Ia8002ec678775f6349020b90766423987a4f714b
Reviewed-on: https://chromium-review.googlesource.com/c/1311853
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#604463}(cherry picked from commit 0c509ea6b33ff5f43ff476e223cffa337db0eb4f)
Reviewed-on: https://chromium-review.googlesource.com/c/1318381
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#504}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Fixed (was: Started)
Thank you for reviewing the request!

Sign in to add a comment