New issue
Advanced search Search tips

Issue 900749 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Improve minizip fuzzers

Project Member Reported by amistry@chromium.org, Oct 31

Issue description

'nuff said.
 
Summary: Improve minizip fuzzers (was: Move minizip fuzzers from //testing to //third_party/minizip)
Tasks:
- move fuzzers from //testing to //third_party/minizip
- improve functions and argument coverage
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cd170e05d44fcba553014727c1ffa9a69123940

commit 5cd170e05d44fcba553014727c1ffa9a69123940
Author: Anand K. Mistry <amistry@chromium.org>
Date: Tue Nov 06 00:25:21 2018

Move minizip fuzzers to //third_party/minizip

BUG= 900749 

Change-Id: Ia2429113cc5b2bef49e25643fa2176e883029e2b
Reviewed-on: https://chromium-review.googlesource.com/c/1311854
Commit-Queue: Anand Mistry <amistry@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605533}
[modify] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/BUILD.gn
[modify] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/testing/libfuzzer/fuzzers/BUILD.gn
[modify] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/third_party/minizip/BUILD.gn
[modify] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/third_party/minizip/DEPS
[rename] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/third_party/minizip/minizip_compress_fuzzer.cc
[rename] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/third_party/minizip/minizip_uncompress_corpus/As.zip
[rename] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/third_party/minizip/minizip_uncompress_corpus/corpus.zip
[rename] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/third_party/minizip/minizip_uncompress_corpus/empty.zip
[rename] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/third_party/minizip/minizip_uncompress_corpus/encrypted.zip
[rename] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/third_party/minizip/minizip_uncompress_corpus/gh.zip
[rename] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/third_party/minizip/minizip_uncompress_corpus/infozip-symlinks.zip
[rename] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/third_party/minizip/minizip_uncompress_corpus/permissions.zip
[rename] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/third_party/minizip/minizip_uncompress_corpus/storeonly.zip
[rename] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/third_party/minizip/minizip_uncompress_corpus/unsupported_permissions.zip
[rename] https://crrev.com/5cd170e05d44fcba553014727c1ffa9a69123940/third_party/minizip/minizip_uncompress_fuzzer.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88c685f4de0a3fe6a07b97550dfa06a9fec54018

commit 88c685f4de0a3fe6a07b97550dfa06a9fec54018
Author: Anand K. Mistry <amistry@chromium.org>
Date: Tue Nov 06 01:03:47 2018

Improve function and options coverage of minizip fuzzers

BUG= 900749 

Change-Id: Ib83ba2c50723a89f412d6c5a14cecd93b57cbe5b
Reviewed-on: https://chromium-review.googlesource.com/c/1312133
Commit-Queue: Anand Mistry <amistry@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605550}
[modify] https://crrev.com/88c685f4de0a3fe6a07b97550dfa06a9fec54018/third_party/minizip/BUILD.gn
[modify] https://crrev.com/88c685f4de0a3fe6a07b97550dfa06a9fec54018/third_party/minizip/minizip_compress_fuzzer.cc
[modify] https://crrev.com/88c685f4de0a3fe6a07b97550dfa06a9fec54018/third_party/minizip/minizip_uncompress_fuzzer.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2740836b762251b1b8b21983fe46e6f468403b53

commit 2740836b762251b1b8b21983fe46e6f468403b53
Author: Anand K. Mistry <amistry@chromium.org>
Date: Fri Nov 09 01:03:07 2018

More minizip fuzzing improvements

- Add new files to corpus that cover additional zip features
- Cover additional functions

BUG= 900749 

Change-Id: I0cd8b41112035b1ba95ab11155c67aeb8fded29f
Reviewed-on: https://chromium-review.googlesource.com/c/1325572
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606685}
[add] https://crrev.com/2740836b762251b1b8b21983fe46e6f468403b53/third_party/minizip/minizip_uncompress_corpus/comments.zip
[add] https://crrev.com/2740836b762251b1b8b21983fe46e6f468403b53/third_party/minizip/minizip_uncompress_corpus/zip64.zip
[modify] https://crrev.com/2740836b762251b1b8b21983fe46e6f468403b53/third_party/minizip/minizip_uncompress_fuzzer.cc

Status: Fixed (was: Assigned)

Sign in to add a comment