New issue
Advanced search Search tips

Issue 900724 link

Starred by 1 user
Status: Fixed
Owner:
ryansturm@chromium.org
Closed: Nov 1
Cc:
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Add a Previews Browerstest to verify opt outs

Project Member Reported by ryansturm@chromium.org, Oct 31 
Recently, Previews opt outs were not reported appropriately to the client Previews opt out blacklist (https://bugs.chromium.org/p/chromium/issues/detail?id=900711)

We should have a browser test for this case.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72b74d82cd06a5e7c002a9d1e212cff4315c6b71

commit 72b74d82cd06a5e7c002a9d1e212cff4315c6b71
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Thu Nov 01 18:18:49 2018

[Previews] Adding tests to verify opt outs being recorded correctly.

This adds tests to verify that opt outs are actually recorded and
tracked appropriately for Previews.

Bug:  900724 , 778793 
Change-Id: Ib927645256eeeb7df08092eeb80f5652f295edbc
Reviewed-on: https://chromium-review.googlesource.com/c/1311375
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604643}
[modify] https://crrev.com/72b74d82cd06a5e7c002a9d1e212cff4315c6b71/chrome/browser/previews/previews_browsertest.cc
[modify] https://crrev.com/72b74d82cd06a5e7c002a9d1e212cff4315c6b71/chrome/browser/previews/previews_ui_tab_helper_unittest.cc
[modify] https://crrev.com/72b74d82cd06a5e7c002a9d1e212cff4315c6b71/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 2 by ryansturm@chromium.org, Nov 1

Status: Fixed (was: Assigned)
►

Sign in to add a comment