New issue
Advanced search Search tips

Issue 900709 link

Starred by 1 user

Issue metadata

Status: ExternalDependency
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2019-01-18
OS: Fuchsia
Pri: 2
Type: Bug-Regression



Sign in to add a comment

UDPSocketTest.SharedMulticastAddress and JoinMulticastGroup tests fail on Fuchsia

Project Member Reported by w...@chromium.org, Oct 31

Issue description

net_unittests:UDPSocketTest.SharedMulticastAddress and JoinMulticastGroup have been failing since at least https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-rel/5169 with:

[ RUN      ] UDPSocketTest.SharedMulticastAddress
../../net/socket/udp_socket_unittest.cc:694: Failure
Value of: socket1.Listen(receive_address)
Expected: net::OK
  Actual: -4, net::ERR_INVALID_ARGUMENT
Stack trace:
bt#00: pc 0x1ff9ba53d78b (app:/pkg/net_unittests__exec,0x1ee778b)
bt#01: pc 0x1ff9ba53d333 (app:/pkg/net_unittests__exec,0x1ee7333)
bt#02: pc 0x1ff9b9f49bdb (app:/pkg/net_unittests__exec,0x18f3bdb)
bt#03: end

[  FAILED  ] UDPSocketTest.SharedMulticastAddress (51 ms)

and

[ RUN      ] UDPSocketTest.JoinMulticastGroup
../../net/socket/udp_socket_unittest.cc:661: Failure
Value of: socket.Bind(bind_address)
Expected: net::OK
  Actual: -4, net::ERR_INVALID_ARGUMENT
Stack trace:
bt#00: pc 0x1ff9ba53d78b (app:/pkg/net_unittests__exec,0x1ee778b)
bt#01: pc 0x1ff9ba53d333 (app:/pkg/net_unittests__exec,0x1ee7333)
bt#02: pc 0x1ff9b9f49123 (app:/pkg/net_unittests__exec,0x18f3123)
bt#03: end

../../net/socket/udp_socket_unittest.cc:662: Failure
Value of: socket.JoinGroup(group_ip)
Expected: net::OK
  Actual: -15, net::ERR_SOCKET_NOT_CONNECTED
Stack trace:
bt#00: pc 0x1ff9ba53d78b (app:/pkg/net_unittests__exec,0x1ee778b)
bt#01: pc 0x1ff9ba53d333 (app:/pkg/net_unittests__exec,0x1ee7333)
bt#02: pc 0x1ff9b9f491cc (app:/pkg/net_unittests__exec,0x18f31cc)
bt#03: end

../../net/socket/udp_socket_unittest.cc:665: Failure
Value of: socket.LeaveGroup(group_ip)
Expected: net::OK
  Actual: -15, net::ERR_SOCKET_NOT_CONNECTED
Stack trace:
bt#00: pc 0x1ff9ba53d78b (app:/pkg/net_unittests__exec,0x1ee778b)
bt#01: pc 0x1ff9ba53d333 (app:/pkg/net_unittests__exec,0x1ee7333)
bt#02: pc 0x1ff9b9f4932d (app:/pkg/net_unittests__exec,0x18f332d)
bt#03: end

[  FAILED  ] UDPSocketTest.JoinMulticastGroup (21 ms)

 
Cc: ericorth@chromium.org
Components: Internals>PlatformIntegration
SharedMulticastAddress was added by https://chromium-review.googlesource.com/c/chromium/src/+/1298298 which also changed the way that JoinMulticastGroup is initialized.

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70536c5b1d5a3c52c1f30e72e0d5cd86bf908888

commit 70536c5b1d5a3c52c1f30e72e0d5cd86bf908888
Author: Wez <wez@chromium.org>
Date: Thu Nov 01 00:07:36 2018

[Fuchsia] Clean up failing multicast UDPSocketTest tests.

Newly-added SharedMulticastAddress fails on Fuchsia, and the existing
JoinMulticastGroup test now fails due to a change in the parameters
passed to Listen() for non-Windows.

Bug: 900709
Change-Id: Ia98ec45897f88696e7eb872938822040ab5940c6
Reviewed-on: https://chromium-review.googlesource.com/c/1311662
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604456}
[modify] https://crrev.com/70536c5b1d5a3c52c1f30e72e0d5cd86bf908888/net/dns/mdns_client.cc
[modify] https://crrev.com/70536c5b1d5a3c52c1f30e72e0d5cd86bf908888/net/socket/udp_socket_unittest.cc

NextAction: 2018-11-09
Status: ExternalDependency (was: Started)
Filed Fuchsia bug NET-1804 for this. Will follow-up when there is an update; seems like this is something that should Just Work.
Labels: -Pri-1 Pri-2
I'm curious why this passed the fuscia_x64 tryjob when I submitted the original change.  Did something change since then, or was the tryjob for some reason unhelpful?
Eric: net_unittests isn't run on the CQ yet.
The NextAction date has arrived: 2018-11-09
NextAction: 2018-11-23
Changes have been landed as per NET-1804 to implement SO_REUSEPORT, but joining multiple UDP multicast sockets to the same address+port is still not working yet.
The NextAction date has arrived: 2018-11-23
NextAction: 2019-01-18

Comment 11 by monor...@bugs.chromium.org, Jan 18 (4 days ago)

The NextAction date has arrived: 2019-01-18

Sign in to add a comment