State update timer times out too often. |
|||||||
Issue descriptionIME operations which doesn't update any of text content and cursor position and selection range don't call observer methods. In those cases, the timer always times out. Repro steps: 1. Install Swiftkey from Playstore 2. Switch to it. 3. Focus on text field with text on browser. then you'll see a lag.
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddde5a12ea97520b7c9529e5a28b85f64db27a5d commit ddde5a12ea97520b7c9529e5a28b85f64db27a5d Author: Yuichiro Hanada <yhanada@chromium.org> Date: Thu Nov 01 02:20:28 2018 Reduce the chance of timeout of text input state update timer. InputConnectionImpl waits for text input state updates by observer methods. However, some IME operations (like deleting '0' character) don't update the state. Also this CL stops ArcInputMethodManagerService observing OnCompositionBoundsChanged() because it's often called before text input state is updated. Bug: 900707 Test: Ran on DUT. Change-Id: Ib4c79ae19f0175d46e9ecf3cf0cac909f02fac3e Reviewed-on: https://chromium-review.googlesource.com/c/1311313 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#604489} [modify] https://crrev.com/ddde5a12ea97520b7c9529e5a28b85f64db27a5d/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service.cc [modify] https://crrev.com/ddde5a12ea97520b7c9529e5a28b85f64db27a5d/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service_unittest.cc [modify] https://crrev.com/ddde5a12ea97520b7c9529e5a28b85f64db27a5d/chrome/browser/chromeos/arc/input_method_manager/input_connection_impl.cc
,
Nov 2
request merge to M-71.
,
Nov 2
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 5
Merge approved for ChromeOS M71
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/687139c52848cf782c010033d85b22170ae28279 Commit: 687139c52848cf782c010033d85b22170ae28279 Author: yhanada@chromium.org Commiter: yhanada@chromium.org Date: 2018-11-05 19:03:26 +0000 UTC Reduce the chance of timeout of text input state update timer. InputConnectionImpl waits for text input state updates by observer methods. However, some IME operations (like deleting '0' character) don't update the state. Also this CL stops ArcInputMethodManagerService observing OnCompositionBoundsChanged() because it's often called before text input state is updated. Bug: 900707 Test: Ran on DUT. Change-Id: Ib4c79ae19f0175d46e9ecf3cf0cac909f02fac3e Reviewed-on: https://chromium-review.googlesource.com/c/1311313 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604489}(cherry picked from commit ddde5a12ea97520b7c9529e5a28b85f64db27a5d) Reviewed-on: https://chromium-review.googlesource.com/c/1318384 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#505} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/687139c52848cf782c010033d85b22170ae28279 commit 687139c52848cf782c010033d85b22170ae28279 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Mon Nov 05 19:03:26 2018 Reduce the chance of timeout of text input state update timer. InputConnectionImpl waits for text input state updates by observer methods. However, some IME operations (like deleting '0' character) don't update the state. Also this CL stops ArcInputMethodManagerService observing OnCompositionBoundsChanged() because it's often called before text input state is updated. Bug: 900707 Test: Ran on DUT. Change-Id: Ib4c79ae19f0175d46e9ecf3cf0cac909f02fac3e Reviewed-on: https://chromium-review.googlesource.com/c/1311313 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604489}(cherry picked from commit ddde5a12ea97520b7c9529e5a28b85f64db27a5d) Reviewed-on: https://chromium-review.googlesource.com/c/1318384 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#505} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/687139c52848cf782c010033d85b22170ae28279/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service.cc [modify] https://crrev.com/687139c52848cf782c010033d85b22170ae28279/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service_unittest.cc [modify] https://crrev.com/687139c52848cf782c010033d85b22170ae28279/chrome/browser/chromeos/arc/input_method_manager/input_connection_impl.cc
,
Nov 5
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by yhanada@chromium.org
, Oct 31