New issue
Advanced search Search tips

Issue 900699 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 900705



Sign in to add a comment

End to end testing of experimental loading hints

Project Member Reported by tbansal@chromium.org, Oct 31

Issue description

We should do a manual end to end testing of experimental loading hints. The testing should ensure that the experimental hints are loaded only if the corresponding finch trial is enabled.

To provide continuous coverage, we should also add a browser test for it.
 
Blocking: 900705
Here is a component that has experimental loading hints
hintswithads.zip
66.4 KB Download
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c28f7c1ed071c7ac333edf0ec52d5d39257c7e1

commit 2c28f7c1ed071c7ac333edf0ec52d5d39257c7e1
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon Nov 05 17:57:16 2018

Resource loading hints browsertests for experimental hints

Add few browser tests that create component info with
experimental and/or default loading hints. Then, load a webpage
to verify that the resources specified by experimental/default
hints are blocked based on the finch experiment settings.

Change-Id: Id2d20d6f696d8de88a8cf0ed65a319ed67e9a500
Bug:  900699 
Reviewed-on: https://chromium-review.googlesource.com/c/1314135
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605377}
[modify] https://crrev.com/2c28f7c1ed071c7ac333edf0ec52d5d39257c7e1/chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
[modify] https://crrev.com/2c28f7c1ed071c7ac333edf0ec52d5d39257c7e1/components/optimization_guide/test_component_creator.cc
[modify] https://crrev.com/2c28f7c1ed071c7ac333edf0ec52d5d39257c7e1/components/optimization_guide/test_component_creator.h

Status: Fixed (was: Assigned)

Sign in to add a comment