New issue
Advanced search Search tips

Issue 900674 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK failure in IsNumber() in objects-inl.h

Project Member Reported by ClusterFuzz, Oct 31

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5077843061768192

Fuzzer: ochang_js_fuzzer_win
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  IsNumber() in objects-inl.h
  v8::platform::PrintStackTrace
  v8::internal::Object::Number
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=56772:56773

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5077843061768192

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 31

Labels: Test-Predator-Auto-Owner
Owner: bmeu...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/d0ae91ee7ebe77930f7cc86e5f1f92192e41fcfb ([turbofan] Fix Promise.resolve() lowering.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Labels: Security_Impact-Head M-71 OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac Pri-1
Pessimistically assuming this could affect all V8 platforms. If that's not the case, please go ahead un-check those boxes. :)
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 1

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 1

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: bmeu...@chromium.org
Owner: mslekova@chromium.org
Status: Started (was: Assigned)
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable  ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
Labels: -Security_Severity-High -Security_Impact-Beta -ReleaseBlock-Stable
This issue is not relevant to our shipping configuration.
Labels: -Type-Bug-Security -Restrict-View-SecurityTeam Type-Bug
If it's not code we ship in Chrome then it's not a security bug at all, just a regular bug.
Labels: -M-71
Thank you for properly labeling the bug! The bug is only in d8, which is not shipping with Chrome indeed.

Removing the M-71 as well.
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/607033a9e4c0f8a9959a469b64abba3317a0905a

commit 607033a9e4c0f8a9959a469b64abba3317a0905a
Author: Maya Lekova <mslekova@chromium.org>
Date: Wed Nov 14 15:29:09 2018

[async-hooks] Fix Promise.resolve optimization with async hooks enabled

Promise.resolve shouldn't be optimized when the async hooks are enabled.

Bug:  chromium:900674 
Change-Id: I225c3d9002f293395993ded37a1d475635467a94
Reviewed-on: https://chromium-review.googlesource.com/c/1335693
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57505}
[modify] https://crrev.com/607033a9e4c0f8a9959a469b64abba3317a0905a/src/compiler/js-native-context-specialization.cc
[add] https://crrev.com/607033a9e4c0f8a9959a469b64abba3317a0905a/test/mjsunit/regress/regress-crbug-900674.js

Status: Fixed (was: Started)
Project Member

Comment 13 by ClusterFuzz, Nov 15

ClusterFuzz has detected this issue as fixed in range 57504:57505.

Detailed report: https://clusterfuzz.com/testcase?key=5077843061768192

Fuzzer: ochang_js_fuzzer_win
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  IsNumber() in objects-inl.h
  v8::platform::PrintStackTrace
  v8::internal::Object::Number
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=56772:56773
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=57504:57505

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5077843061768192

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 14 by ClusterFuzz, Nov 15

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5077843061768192 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment