New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 900673 link

Starred by 1 user
Status: Started
Owner:
dewittj@chromium.org
Cc:
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Add internals page for moar debugging.

Project Member Reported by dewittj@chromium.org, Oct 31 
We could use some debugging tools to show the different catalogs. Some feature requests:

delete catalog
force catalog refresh,
country override...

show:
* experiment tags,
* current version_token,
* when downloaded,
* catalog country,
* flag status on the page
* possibly DB size

stretch:logging
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/894860e6292919d0d93244a125840d6495712493

commit 894860e6292919d0d93244a125840d6495712493
Author: Justin DeWitt <dewittj@chromium.org>
Date: Tue Dec 18 23:25:25 2018

[EoS] Add infrastructure to allow internals page to work with EoS.

This adds:
* Clear catalog task to remove existing catalogs
* Facility for updating the desired country in memory
* Facility for forcing a network update.

Bug: 900673
Change-Id: I0eeb116df47c5979a3557792c4b898ff3e6d1e85
Reviewed-on: https://chromium-review.googlesource.com/c/1383326
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617669}
[modify] https://crrev.com/894860e6292919d0d93244a125840d6495712493/chrome/browser/BUILD.gn
[add] https://crrev.com/894860e6292919d0d93244a125840d6495712493/chrome/browser/android/explore_sites/clear_catalog_task.cc
[add] https://crrev.com/894860e6292919d0d93244a125840d6495712493/chrome/browser/android/explore_sites/clear_catalog_task.h
[add] https://crrev.com/894860e6292919d0d93244a125840d6495712493/chrome/browser/android/explore_sites/clear_catalog_task_unittest.cc
[modify] https://crrev.com/894860e6292919d0d93244a125840d6495712493/chrome/browser/android/explore_sites/explore_sites_fetcher.cc
[modify] https://crrev.com/894860e6292919d0d93244a125840d6495712493/chrome/browser/android/explore_sites/explore_sites_fetcher.h
[modify] https://crrev.com/894860e6292919d0d93244a125840d6495712493/chrome/browser/android/explore_sites/explore_sites_fetcher_unittest.cc
[modify] https://crrev.com/894860e6292919d0d93244a125840d6495712493/chrome/browser/android/explore_sites/explore_sites_service.h
[modify] https://crrev.com/894860e6292919d0d93244a125840d6495712493/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/894860e6292919d0d93244a125840d6495712493/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[modify] https://crrev.com/894860e6292919d0d93244a125840d6495712493/chrome/browser/android/explore_sites/explore_sites_service_impl_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8

commit ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8
Author: Justin DeWitt <dewittj@chromium.org>
Date: Fri Dec 21 00:55:15 2018

[Eos] Add WebUI infrastructure for serving the internals page.

* Adds chrome://explore-sites-internals to webui urls
* Adds a mojom file defining the interface, and the UI and handler classes
as required by Mojo webui pages.
* Implements the interface on native side.
* Adds a placeholder HTML page.

This leaves the JS/CSS/HTML work to a future CL.

Bug: 900673
Change-Id: Ic3506010828e9db385099d9289f45d69861e05c4
Reviewed-on: https://chromium-review.googlesource.com/c/1383491
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618409}
[modify] https://crrev.com/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8/chrome/browser/browser_resources.grd
[add] https://crrev.com/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8/chrome/browser/resources/explore_sites_internals/OWNERS
[add] https://crrev.com/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8/chrome/browser/resources/explore_sites_internals/explore_sites_internals.html
[modify] https://crrev.com/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[add] https://crrev.com/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8/chrome/browser/ui/webui/explore_sites_internals/BUILD.gn
[add] https://crrev.com/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8/chrome/browser/ui/webui/explore_sites_internals/OWNERS
[add] https://crrev.com/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8/chrome/browser/ui/webui/explore_sites_internals/explore_sites_internals.mojom
[add] https://crrev.com/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8/chrome/browser/ui/webui/explore_sites_internals/explore_sites_internals_page_handler.cc
[add] https://crrev.com/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8/chrome/browser/ui/webui/explore_sites_internals/explore_sites_internals_page_handler.h
[add] https://crrev.com/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8/chrome/browser/ui/webui/explore_sites_internals/explore_sites_internals_ui.cc
[add] https://crrev.com/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8/chrome/browser/ui/webui/explore_sites_internals/explore_sites_internals_ui.h
[modify] https://crrev.com/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/ab0964c8389a5ea5c6fa379a2ac5e4932c9793a8/chrome/common/webui_url_constants.h
►

Sign in to add a comment