New issue
Advanced search Search tips

Issue 900670 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ippusbxd crashing on ARM devices with Epson XP-640

Project Member Reported by valleau@chromium.org, Oct 31

Issue description

OS: Chrome

What steps will reproduce the problem?
(1) Attempt to add an Epson XP-640 using USB

What is the expected result?
The printer will be automatically configured and added

What happens instead?
The ippusbxd program crashes, resulting in a failure to automatically configure the printer.
 
I've determined that this failure is caused by ippusbxd attempting to broadcast the connected device using dnssd. For this specific printer, one of the necessary fields for this broadcasting is not present, which results in a crash as ippusbxd must not validate the input correctly.

The simple fix is to just disable dnssd broadcasting, we don't want to broadcast the devices anyways, and it will prevent this particular failure.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1e76234150e6194ad811b5faff90ce880929165e

commit 1e76234150e6194ad811b5faff90ce880929165e
Author: David Valleau <valleau@chromium.org>
Date: Thu Nov 01 04:59:27 2018

ippusb_manager: Adding no-broadcast flag for ippusbxd startup

This change will prevent ippusbxd from attempting to broadcast the
connected printer using dnssd.

BUG= chromium:900670 
TEST=Tested manually on asuka and veyron_minnie devices

Change-Id: I9e5be34029688131150242c9afa3fa7644c18b1c
Reviewed-on: https://chromium-review.googlesource.com/1310538
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/1e76234150e6194ad811b5faff90ce880929165e/ippusb_manager/ippusb_manager.cc

Labels: Merge-Request-71
Requesting merge approval for M71
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 2

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Merge approved for ChromeOS M71
Labels: M-71
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 6

Labels: merge-merged-release-R71-11151.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4f51cb296375764606b1bd53d1bf28f79330d58c

commit 4f51cb296375764606b1bd53d1bf28f79330d58c
Author: David Valleau <valleau@chromium.org>
Date: Tue Nov 06 19:29:27 2018

ippusb_manager: Adding no-broadcast flag for ippusbxd startup

This change will prevent ippusbxd from attempting to broadcast the
connected printer using dnssd.

BUG= chromium:900670 
TEST=Tested manually on asuka and veyron_minnie devices

Change-Id: I9e5be34029688131150242c9afa3fa7644c18b1c
Reviewed-on: https://chromium-review.googlesource.com/1310538
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
(cherry picked from commit 1e76234150e6194ad811b5faff90ce880929165e)
Reviewed-on: https://chromium-review.googlesource.com/c/1319978
Trybot-Ready: David Valleau <valleau@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/4f51cb296375764606b1bd53d1bf28f79330d58c/ippusb_manager/ippusb_manager.cc

Labels: -Merge-Approved-71
Status: Fixed (was: Started)
Fix landed in:

M72 11217.0.0
M71 11151.23.0
Corresponding Chrome releases:
	71.0.3578.45
	72.0.3606.0
Issue 810123 has been merged into this issue.

Sign in to add a comment