New issue
Advanced search Search tips

Issue 900667 link

Starred by 1 user
Status: Fixed
Owner:
mrefaat@chromium.org
Closed: Dec 3
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug
q4
iOS

Blocked on:
issue 778416


Sign in to add a comment

[iOS] ProgrammaticVoiceSearchNavigationsTest/VoiceSearchNavigationsTest.NotVoiceSearchNavigation/1 is failing

Project Member Reported by kkhorimoto@chromium.org, Oct 31 
Seems to be due to an unexpected scheme:

[1457:8451:1031/101240.781596:1258043584795:FATAL:browser_about_rewriter.cc(35)] Check failed: (*url == url::kAboutBlankURL) || !url->SchemeIs(url::kAboutScheme).
0   ios_chrome_unittests                0x0000000108e6ec5d base::debug::StackTrace::StackTrace(unsigned long) + 157
1   ios_chrome_unittests                0x0000000108e6ec9d base::debug::StackTrace::StackTrace(unsigned long) + 29
2   ios_chrome_unittests                0x0000000108b4237a base::debug::StackTrace::StackTrace() + 26
3   ios_chrome_unittests                0x0000000108b8546d logging::LogMessage::~LogMessage() + 461
4   ios_chrome_unittests                0x0000000108b83115 logging::LogMessage::~LogMessage() + 21
5   ios_chrome_unittests                0x000000010764ab06 WillHandleWebBrowserAboutURL(GURL*, web::BrowserState*) + 646
6   ios_chrome_unittests                0x00000001077a2034 web::BrowserURLRewriter::RewriteURLWithWriters(GURL*, web::BrowserState*, std::__1::vector<bool ()(GURL, web::BrowserState*), std::__1::allocator<bool ()(GURL, web::BrowserState*)> > const&) + 420
7   ios_chrome_unittests                0x00000001077a2c19 web::BrowserURLRewriterImpl::RewriteURLIfNecessary(GURL*, web::BrowserState*) + 41
8   ios_chrome_unittests                0x00000001077d1988 web::NavigationManagerImpl::CreateNavigationItemWithRewriters(GURL const&, web::Referrer const&, ui::PageTransition, web::NavigationInitiationType, GURL const&, std::__1::vector<bool ()(GURL, web::BrowserState*), std::__1::allocator<bool ()(GURL, web::BrowserState*)> > const*) const + 376
9   ios_chrome_unittests                0x00000001078fcdf3 web::WKBasedNavigationManagerImpl::AddPendingItem(GURL const&, web::Referrer const&, ui::PageTransition, web::NavigationInitiationType, web::NavigationManager::UserAgentOverrideOption) + 323
10  ios_chrome_unittests                0x00000001077d2a9d web::NavigationManagerImpl::LoadURLWithParams(web::NavigationManager::WebLoadParams const&) + 429
11  ios_chrome_unittests                0x0000000108222bd2 web::WebTestWithWebState::LoadHtml(NSString*, GURL const&) + 1042
12  ios_chrome_unittests                0x00000001082242cc web::WebTestWithWebState::LoadHtml(NSString*) + 124
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/182718002271024700ec74460072779cee29b96a

commit 182718002271024700ec74460072779cee29b96a
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Wed Oct 31 18:44:51 2018

[iOS] Disable failing VoiceSearchNavigations test.

This CL disables VoiceSearchNavigationsTest.NotVoiceSearchNavigation.

TBR=justincohen@chromium.org

Bug:  900667 
Change-Id: I662e767f993c151ca133b48d0afe654707548c7b
Reviewed-on: https://chromium-review.googlesource.com/c/1310560
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604350}
[modify] https://crrev.com/182718002271024700ec74460072779cee29b96a/ios/chrome/browser/voice/voice_search_navigations_tab_helper_unittest.mm

Comment 2 by mrefaat@google.com, Nov 28

Blockedon: 778416
Labels: iOS S-ios-voice-search ios-tab-refactoring small O-ios-tab-refactoring-extras
Owner: mrefaat@chromium.org
Going to remove tests related to voiceSearchNavigationItem calls as part of tab refactoring.

Comment 3 by mrefaat@google.com, Dec 3

Labels: q4

Comment 4 by mrefaat@google.com, Dec 3

Status: Fixed (was: Started)
https://chromium-review.googlesource.com/c/chromium/src/+/1355765 Updates unit tests

Comment 5 by mrefaat@google.com, Dec 3

Labels: -Restrict-View-Google
►

Sign in to add a comment