Constant draw&swap on NTP page with today's doodle (10/31) even though it has no visual changes. |
|||
Issue descriptionGoogle Chrome 70.0.3538.76 (Official Build) beta (64-bit) Revision 22757df8a5ddfacf2eaf57b85f4ea54c14b8f87a-refs/branch-heads/3538@{#1031} Platform 11021.56.0 (Official Build) beta-channel eve Repro step: 1) record cc trace while NTP is opened with halloween doodle. See the attached trace. It looks to me that page constantly update frames? On www.google.com, the doodle animates, but on NTP it doesn't so I'd expect it shouldn't do draw&swap. enne@ do you know where to route this?
,
Oct 31
1) no flag enabled. 2) yes, only difference is that play button animates on www.google.com, while it doesn't on NTP. I also tested on ToT and had same behavior. I also tested normal NTP w/o doogle and this didn't happen.
,
Oct 31
Can you point to some info about how the trace was trace captured? Does the draw & swap only occur on CrOS, and does it it impact perf?
,
Oct 31
Here is what I did 1) open two tabs, chrome://tracing and NTP 2) start tracing 3) switch to NTP, waited for a while 4) switch back to chrome://traching I just noticed this while looking to animation jank issue, and want to know if this is expected, or something that we can fix or improve. I'm looking into more generic way to improve animation (by suspending frame updates during animation), so this won't be an issue for perf (hopefully). It can potentially impact battery performance though.
,
Oct 31
Thanks for the very detailed response. This seems specific to this doodle. Adding jshneier@ to comment on whether it's expected.
,
Oct 31
The doodle doesn't show any animation in its initial state on NTP, but it does start its render loop immediately instead of waiting for the first click. Apologies for that, we wrote a new implementation of our main render loop for this one and didn't think to optimize this case. We'll make a note for future doodles.
,
Oct 31
We do stop the render loop when the tab is not visible, however (per the page visibility api).
,
Oct 31
#c6 & #c7: Thanks for the explanation. Given that this issue is specific to the Halloween Doodle (which has limited time remaining), and impact is pretty minimal, I'm going to mark this bug as WontFix. Thanks for your report oshima@!
,
Nov 1
sg, thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by ramyan@chromium.org
, Oct 31