New issue
Advanced search Search tips

Issue 900640 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Regression: The "disabled" property in oobe_buttons no longer disables click event

Project Member Reported by wzang@chromium.org, Oct 31

Issue description

The implementation of the "disabled" property uses the event handler in paper-button:   https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/oobe_buttons.js?q=oobe_buttons.js&dr&l=31

onClick_ should receive the event first, and if the "oobe-text-button" has "disabled" property, the event should stop bubbling up, therefore any event handlers in "oobe-text-button" should be no-op, and the button is effectively disabled.

However, right now click events can never reach the "paper-button" level: we found that the event only reaches the outer level of "oobe-text-button", but does not go down.

This looks very similar to the "closed-shadow" section in https://developer.mozilla.org/en-US/docs/Web/API/Event/composed. However, this should be a regression since it used to work.

 
The bug is not very observable, I guess it's because:

1) The "disabled" state is often very short, e.g. the Eula accept button is only disabled while waiting for EULA to load.

2) There're other mechanism to ignore the event, e.g. in the network selection screen, when the user does not select any network and attempts to click on the disabled "next" button, the event is still fired because of this bug, but there's no visible UI change because it's guarded by the c++ side.
Cc: haraken@chromium.org
Components: -Blink Blink>DOM>ShadowDOM
Labels: Hotlist-OOBE-polish
Status: Available (was: Untriaged)

Sign in to add a comment