New issue
Advanced search Search tips

Issue 900638 link

Starred by 1 user
Status: Fixed
Owner:
sunxd@chromium.org
Closed: Nov 5
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Fix /2 viz hit testing metrics

Project Member Reported by sunxd@chromium.org, Oct 31 
Because we introduced verification code path, the async event targeting metric ResponseTime is messed up. It also counts verfication requests in but it shouldn't. We need to fix this.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00796e73b869e4a4fcc68f0f7ba35f6c54ef0073

commit 00796e73b869e4a4fcc68f0f7ba35f6c54ef0073
Author: Xianda Sun <sunxd@chromium.org>
Date: Wed Oct 31 21:33:34 2018

Do not record Event.AsyncTargeting.ResponseTime when verifying results

We now count async verifying time in Event.AsyncTargeting.ResponseTime
and this is not expected. This patch excludes verifying data from the
metric.

Bug:  900638 
Change-Id: Ida75dc486746f033d6f2563846e37ebf6ee00ee9
Reviewed-on: https://chromium-review.googlesource.com/c/1310453
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604379}
[modify] https://crrev.com/00796e73b869e4a4fcc68f0f7ba35f6c54ef0073/content/browser/renderer_host/render_widget_targeter.cc

Comment 2 by sunxd@chromium.org, Nov 5

Status: Fixed (was: Started)
►

Sign in to add a comment