Launcher button seems unresponsive |
|||||||||
Issue descriptionChrome Version: 72.0.3593.0 What steps will reproduce the problem? (1) Show shelf. (2) Tap the launcher button. What is the expected result? Launcher easily shows up on the first try. What happens instead? Initial investigation shows that the launcher button is not receiving these events, they are going the shelf. It feels like I am tapping the button though. Maybe we should give this button a larger touch target, or give more margin for error for this button. It is tricky to press sometimes, see the repro video. Please note, I'm not sure how long this has been this way, or if my thumb is just not shaped normally. Video: https://photos.app.goo.gl/mKJfMyV4igccErCz8
,
Nov 14
I did some investigations here, it seems like ShelfView::OnGestureEvent is called even when the event bounds are within the app list buttons bounds. I can't repro this on the emulator, only on device.
,
Nov 14
Issue 894653 has been merged into this issue.
,
Nov 14
,
Nov 15
Bisected to https://chromium-review.googlesource.com/1198525
,
Nov 15
,
Nov 15
Looks like the launcher button went from the old size, 48, up to 56 temporarily, then back down to 40. I'm guessing 40 is just a bit too small.
,
Nov 16
Looks like the actual cause of the bug is the nefarious back_and_app_list_background_ which was stealing events before they could get to the AppListButton.
,
Nov 16
I have a pretty safe 1 line fix. https://chromium-review.googlesource.com/c/chromium/src/+/1338723/
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/879b37c6c751745d8c9d9dcf67e1f5958991307f commit 879b37c6c751745d8c9d9dcf67e1f5958991307f Author: Alex Newcomer <newcomer@chromium.org> Date: Fri Nov 16 16:34:29 2018 cros: Fix unresponsive app list button |back_and_app_list_background_| is interfering with event targeting and causing the app list button to be unresponsive, specifically in the right side of the button. NOTE: This only repros on device, not on the emulator. Prevent |back_and_app_list_background_| from recieving events to prevent this. Bug: 900632 Change-Id: Ib2cd8e51cb560d84307904c86ae46ecc388e2424 Reviewed-on: https://chromium-review.googlesource.com/c/1338723 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#608796} [modify] https://crrev.com/879b37c6c751745d8c9d9dcf67e1f5958991307f/ash/shelf/shelf_view.cc
,
Nov 16
I know it's late, but this is a huge quality of life improvement (especially on nocturne), and it is a very safe 1 line fix.
,
Nov 17
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 19
Approved for M71 ChromeOS.
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73ef1380dda8ccb4e14845a1692cb095a416aa46 Commit: 73ef1380dda8ccb4e14845a1692cb095a416aa46 Author: newcomer@chromium.org Commiter: newcomer@chromium.org Date: 2018-11-19 16:43:03 +0000 UTC cros: Fix unresponsive app list button |back_and_app_list_background_| is interfering with event targeting and causing the app list button to be unresponsive, specifically in the right side of the button. NOTE: This only repros on device, not on the emulator. Prevent |back_and_app_list_background_| from recieving events to prevent this. Bug: 900632 Change-Id: Ib2cd8e51cb560d84307904c86ae46ecc388e2424 Reviewed-on: https://chromium-review.googlesource.com/c/1338723 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#608796}(cherry picked from commit 879b37c6c751745d8c9d9dcf67e1f5958991307f) Reviewed-on: https://chromium-review.googlesource.com/c/1342398 Cr-Commit-Position: refs/branch-heads/3578@{#751} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73ef1380dda8ccb4e14845a1692cb095a416aa46 commit 73ef1380dda8ccb4e14845a1692cb095a416aa46 Author: Alex Newcomer <newcomer@chromium.org> Date: Mon Nov 19 16:43:03 2018 cros: Fix unresponsive app list button |back_and_app_list_background_| is interfering with event targeting and causing the app list button to be unresponsive, specifically in the right side of the button. NOTE: This only repros on device, not on the emulator. Prevent |back_and_app_list_background_| from recieving events to prevent this. Bug: 900632 Change-Id: Ib2cd8e51cb560d84307904c86ae46ecc388e2424 Reviewed-on: https://chromium-review.googlesource.com/c/1338723 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#608796}(cherry picked from commit 879b37c6c751745d8c9d9dcf67e1f5958991307f) Reviewed-on: https://chromium-review.googlesource.com/c/1342398 Cr-Commit-Position: refs/branch-heads/3578@{#751} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/73ef1380dda8ccb4e14845a1692cb095a416aa46/ash/shelf/shelf_view.cc
,
Nov 19
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by newcomer@chromium.org
, Nov 9