Non-Regression: Edit Text does not update when multiple items are selected in gallery when starting with nothing selected. |
||
Issue descriptionChrome Version : M70 What steps will reproduce the problem? (1) Open the gallery app in Chrome OS. (2) Go to thumbnail mode. (3) Unselect all thumbnails. (4) Hold down shift and click the last thumbnail (needs to have more than one thumbail). What is the expected result? The edit text says : x items selected What happens instead? The edit text does not update. This does not hold true if there is an item selected and a shift click happens. Please provide any additional information below. Attach a screenshot if possible.
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1736180299ddf1b5c35434afec2f4097e6be6308 commit 1736180299ddf1b5c35434afec2f4097e6be6308 Author: Alexander Nohe <nohe@chromium.org> Date: Mon Nov 05 01:40:20 2018 Edit text does not update when multiple items are selected Set the index to the first image when there are no images selected. This change will allow the edit text to appear visible when shift selecting all the images in the gallery. Bug: 900619 Change-Id: I673b8ab229e9e665b2852d3e0c9d357dc82a40bc Reviewed-on: https://chromium-review.googlesource.com/c/1309997 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alexander Nohe <nohe@chromium.org> Cr-Commit-Position: refs/heads/master@{#605226} [modify] https://crrev.com/1736180299ddf1b5c35434afec2f4097e6be6308/chrome/browser/chromeos/file_manager/gallery_browsertest.cc [modify] https://crrev.com/1736180299ddf1b5c35434afec2f4097e6be6308/ui/file_manager/file_manager/background/js/test_util_base.js [modify] https://crrev.com/1736180299ddf1b5c35434afec2f4097e6be6308/ui/file_manager/gallery/js/thumbnail_mode.js [modify] https://crrev.com/1736180299ddf1b5c35434afec2f4097e6be6308/ui/file_manager/integration_tests/gallery/thumbnail_mode.js
,
Nov 5
|
||
►
Sign in to add a comment |
||
Comment 1 by nohe@chromium.org
, Oct 31