New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 900618 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----


Participants' hotlists:
Launcher-Polish


Sign in to add a comment

Shelf has a background for a few seconds after the launcher closes (janky)

Project Member Reported by newcomer@chromium.org, Oct 31

Issue description

Chrome Version: 72.0.3593.0
What steps will reproduce the problem?
(1) Set the shelf to autohide.
(2) Open something so the shelf hides.
(3) Swipe up to show the shelf.
(4) Swipe up enough to show the launcher, but release before the threshold so the launcher does not actually show, and it animates to shelf height and hides the launcher.

What is the expected result?
Launcher animates to shelf height, then shelf smoothly animates to the bottom of the screen.

What happens instead?
When the finger is released, the shelf gets its background instantly, and the shelf and launcher both animate to the bottom of the screen but at different speeds. This seems pretty janky.

Video:
https://photos.app.goo.gl/9T8X5jQvE7t3Wgsj9

Again, not sure if this is launcher or shelf, please pass it back if you don't have time.
 
We used to have issues because launcher/shelf were in different processes (ash/browser) and it was hard to tell shelf when the launcher animation was over.

We should be able to do this better now that we are in the same process. Also we should probably look at launcher animation speed vs shelf animation speed.

Currently launcher animations animate from peeking/half to the bottom at 200ms, and from fullscreen to the bottom in 250ms.

UX: Should we animate over a constant speed instead of these arbitrary values?
I think the idea behind these two values was to get more steps in between the peeking mode and the fullscreen, as the distance was longer,  15 frames looking a bit better than 12. 

I'm not sure I'm getting the correlation between these numbers and what is shown here as these number apply only to launcher and not shelf. What's the curent timing for shelf hiding back down?
Labels: -M-72 M-73
Status: Assigned (was: Available)
Owner: newcomer@chromium.org
Status: Fixed (was: Assigned)
Fixed in top of tree[1]. Shelf doesn't get its background until the launcher reaches shelf height. 

Constant speed questions were covered with mccanny offline.

We decided not to pursue this because the gains were pretty negligible. (willing to talk more offline if you're interested.)


[1] https://chromium-review.googlesource.com/c/chromium/src/+/1370368

Sign in to add a comment