New issue
Advanced search Search tips

Issue 900606 link

Starred by 1 user
Status: Duplicate
Merged: issue 899903
Owner:
csharrison@chromium.org
Closed: Oct 31
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

SubresourceFilterTest#resourceNotFilteredWithWarning timing out on Android CFI

Project Member Reported by tbansal@chromium.org, Oct 31 
org.chromium.chrome.browser.SubresourceFilterTest#resourceNotFilteredWithWarning test is timing out on Android CFI.

Example run: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3479

Part of the stack:
java.lang.AssertionError: Criteria not met in allotted time.
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.chromium.content_public.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:92)
	at org.chromium.content_public.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:171)
	at org.chromium.content_public.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:193)
	at org.chromium.chrome.browser.SubresourceFilterTest.createAndPublishRulesetDisallowingSuffix(SubresourceFilterTest.java:62)
	at org.chromium.chrome.browser.SubresourceFilterTest.setUp(SubresourceFilterTest.java:81)
	at java.lang.reflect.Method.invoke(Method.java)

Assigning to csharrison@ for triage.

Comment 1 by csharrison@chromium.org, Oct 31

Mergedinto: 899903
Status: Duplicate (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4e7eec9b7685fc78827b6d58a6593e52227b7ee

commit e4e7eec9b7685fc78827b6d58a6593e52227b7ee
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Oct 31 16:44:27 2018

Revert "Speculatively Revert "[url_pattern_index] Print matching rule for tracing""

This reverts commit a3bc216e5c72dac2c5bfa5e221b55cfd4db38030.

Reason for revert: Reverting the CL did not fix the flaky test. See  crbug.com/900606 .

Original change's description:
> Speculatively Revert "[url_pattern_index] Print matching rule for tracing"
> 
> This reverts commit 1c7e76655e0f89b5ed683e908d50cbcb3b92f6da.
> 
> Reason for revert:
> Fails test org.chromium.chrome.browser.SubresourceFilterTest#resourceFilteredClose
> See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3471
> 
> Original change's description:
> > [url_pattern_index] Print matching rule for tracing
> > 
> > This is useful for debugging.
> > 
> > Bug: None
> > Change-Id: I8e6260f09b3c17f0a9952739387f70a431571011
> > Reviewed-on: https://chromium-review.googlesource.com/c/1308013
> > Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> > Reviewed-by: Josh Karlin <jkarlin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#603990}
> 
> TBR=jkarlin@chromium.org,csharrison@chromium.org
> 
> Change-Id: I44e487142ab5c3477ff77945a3f2854bb9762056
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: None
> Reviewed-on: https://chromium-review.googlesource.com/c/1308904
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Commit-Queue: Tarun Bansal <tbansal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604073}

TBR=jkarlin@chromium.org,tbansal@chromium.org,csharrison@chromium.org

Bug:  900606 
Change-Id: Ibf69e14dfdc650776d542ce6334102b67317fa89
Reviewed-on: https://chromium-review.googlesource.com/c/1310115
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604295}
[modify] https://crrev.com/e4e7eec9b7685fc78827b6d58a6593e52227b7ee/components/subresource_filter/tools/BUILD.gn
[modify] https://crrev.com/e4e7eec9b7685fc78827b6d58a6593e52227b7ee/components/url_pattern_index/BUILD.gn
[modify] https://crrev.com/e4e7eec9b7685fc78827b6d58a6593e52227b7ee/components/url_pattern_index/url_pattern_index.cc
►

Sign in to add a comment