Absolutely positioned siblings of a <video> element disappear.
Reported by
da...@thisislanguage.com,
Oct 31
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.67 Safari/537.36 Example URL: https://codepen.io/dante-til/pen/KGjJam Steps to reproduce the problem: 1. Go to the link. 2. Wait for it to fully load. 3. Click on the "Play" button on the green panel. What is the expected behavior? The button doesn't change appearance. What went wrong? The button becomes invisible. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes 68 Does this work in other browsers? Yes Chrome version: 70.0.3538.67 Channel: stable OS Version: Ubuntu 16.04 Flash Version: The issue also appears on the Android version of Google Chrome 70. Strangely enough it also appears on Android Firefox Focus but not on Ubuntu Firefox 62. The link provided is a simplified example to showcase the issue. I tried a few workarounds but they fail on various platforms in seemingly random ways.
,
Oct 31
,
Nov 1
dante@ Thanks for the issue. Able to reproduce this issue on Windows 10, Mac OS 10.13.6 and Ubuntu 17.10 on the reported version 70.0.3538.67 and latest Canary 72.0.3596.0. Bisect Information: =================== Good Build: 70.0.3500.0 Bad Build : 70.0.3501.0 As per comment #1, suspecting the below change: Reviewed-on: https://chromium-review.googlesource.com/1142571 As the owner trchen@ is not available, assigning the bug to the reviewer pdr@. pdr@ Please check and confirm if this issue is related to this change, else help us in assigning to the right owner. Adding 'ReleaseBlock-Stable' for M-71 as this is a recent regression. Please feel free to remove if it is not applicable. Thanks..
,
Nov 5
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Nov 5
,
Nov 5
,
Nov 7
,
Nov 8
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Nov 9
,
Nov 13
Reminder M71 Stable is approaching VERY soon. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure any planned work will be tested in Beta and verified before the Stable date. Thank you. Requesting to take a look at M71 blockers ASAP due to upcoming Thanksgiving holidays next week.
,
Nov 14
,
Nov 14
Update: we are still working on this issue and have two potential patches we are evaluating.
,
Nov 14
Update: we're going to take a third approach. Chrishtr and I have designed it. Chris will implement it. For posterity: we're going to prevent squashing under video.
,
Nov 15
Reminder M71 Stable is approaching VERY soon. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure any planned work will be tested in Beta and verified before the Stable date. Thank you. Requesting to take a look at M71 blockers ASAP due to upcoming Thanksgiving holidays next week.
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/346efa24c5a266c09f90c070777544f46094f715 commit 346efa24c5a266c09f90c070777544f46094f715 Author: Chris Harrelson <chrishtr@chromium.org> Date: Thu Nov 15 21:21:08 2018 [Regression] Don't squash into content underneath a video tag. This works around a hard to fix bug in pre-BGPT Blink compositing code that involves mismatches between clips in the property trees and clips in the graphics layers. After BGPT launches, this patch can be reverted, and videos changed to report ShouldClipOverflow() as true on their LayoutBox. Bug: 900602 Change-Id: I76f5d18f2ecd9a10120d96c4a7898b641b5f557a Reviewed-on: https://chromium-review.googlesource.com/c/1337289 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608505} [modify] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [add] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/WebKit/LayoutTests/compositing/video/video-controls-squashing.html [modify] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/WebKit/LayoutTests/paint/invalidation/video-paint-invalidation-expected.txt [add] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-squashing-expected.png [modify] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [add] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/video/video-poster-expected.txt [add] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/WebKit/LayoutTests/platform/mac-mac10.11/compositing/video/video-poster-expected.txt [add] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/WebKit/LayoutTests/platform/mac-retina/compositing/video/video-poster-expected.txt [add] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-squashing-expected.png [modify] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-poster-expected.txt [modify] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [add] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/WebKit/LayoutTests/platform/win/compositing/video/video-controls-squashing-expected.png [modify] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/WebKit/LayoutTests/platform/win/compositing/video/video-poster-expected.txt [modify] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [modify] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc [modify] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.h [modify] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/blink/renderer/core/paint/compositing/compositing_layer_assigner.cc [modify] https://crrev.com/346efa24c5a266c09f90c070777544f46094f715/third_party/blink/renderer/core/paint/paint_layer.h
,
Nov 15
How safe is the change listed at #16 to merge to M71 this late in release cycle? As this is regressed in M70, can this wait until M72?
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2923c55319b49de75b1ed1b4bb4496120364fe3 commit e2923c55319b49de75b1ed1b4bb4496120364fe3 Author: Ella Ge <eirage@chromium.org> Date: Fri Nov 16 00:55:11 2018 Disable video-poster.html on Mac bots TBR=chrishtr@chromium.org Bug: 905860 , 900602 Change-Id: I5d2a01010b4424ffa4312dfaf01e3ca0af24d182 Reviewed-on: https://chromium-review.googlesource.com/c/1338570 Reviewed-by: Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608606} [modify] https://crrev.com/e2923c55319b49de75b1ed1b4bb4496120364fe3/third_party/WebKit/LayoutTests/TestExpectations
,
Nov 16
I will request a merge of this CL after reviewing results on Canary tomorrow. I think this bugfix is quite safe and the use cases that break are widespread.
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab6eb7c4a05309a35de41692f23067c50a8f8444 commit ab6eb7c4a05309a35de41692f23067c50a8f8444 Author: Kentaro Hara <haraken@chromium.org> Date: Fri Nov 16 03:50:30 2018 Revert "[Regression] Don't squash into content underneath a video tag." This reverts commit 346efa24c5a266c09f90c070777544f46094f715. Reason for revert: This broke compositing/video/video-poster.html on WebKit Mac10.13. Maybe we just need to rebaseline? https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Mac10.13%20%28retina%29/6654 The trees are burning now, so allow me to be conservative and revert it just in case. Original change's description: > [Regression] Don't squash into content underneath a video tag. > > This works around a hard to fix bug in pre-BGPT Blink compositing > code that involves mismatches between clips in the property trees > and clips in the graphics layers. > > After BGPT launches, this patch can be reverted, and videos > changed to report ShouldClipOverflow() as true on their LayoutBox. > > Bug: 900602 > > Change-Id: I76f5d18f2ecd9a10120d96c4a7898b641b5f557a > Reviewed-on: https://chromium-review.googlesource.com/c/1337289 > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608505} TBR=pdr@chromium.org,chrishtr@chromium.org Change-Id: I0be4eb8f16d9bc5e0f05c02c57f63646ff048ba6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 900602 Reviewed-on: https://chromium-review.googlesource.com/c/1338587 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#608655} [modify] https://crrev.com/ab6eb7c4a05309a35de41692f23067c50a8f8444/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [delete] https://crrev.com/a490db0acef763009a3eb88253faf910c1774548/third_party/WebKit/LayoutTests/compositing/video/video-controls-squashing.html [modify] https://crrev.com/ab6eb7c4a05309a35de41692f23067c50a8f8444/third_party/WebKit/LayoutTests/paint/invalidation/video-paint-invalidation-expected.txt [delete] https://crrev.com/a490db0acef763009a3eb88253faf910c1774548/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-squashing-expected.png [modify] https://crrev.com/ab6eb7c4a05309a35de41692f23067c50a8f8444/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [delete] https://crrev.com/a490db0acef763009a3eb88253faf910c1774548/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/video/video-poster-expected.txt [delete] https://crrev.com/a490db0acef763009a3eb88253faf910c1774548/third_party/WebKit/LayoutTests/platform/mac-mac10.11/compositing/video/video-poster-expected.txt [delete] https://crrev.com/a490db0acef763009a3eb88253faf910c1774548/third_party/WebKit/LayoutTests/platform/mac-retina/compositing/video/video-poster-expected.txt [delete] https://crrev.com/a490db0acef763009a3eb88253faf910c1774548/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-squashing-expected.png [modify] https://crrev.com/ab6eb7c4a05309a35de41692f23067c50a8f8444/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-poster-expected.txt [modify] https://crrev.com/ab6eb7c4a05309a35de41692f23067c50a8f8444/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [delete] https://crrev.com/a490db0acef763009a3eb88253faf910c1774548/third_party/WebKit/LayoutTests/platform/win/compositing/video/video-controls-squashing-expected.png [modify] https://crrev.com/ab6eb7c4a05309a35de41692f23067c50a8f8444/third_party/WebKit/LayoutTests/platform/win/compositing/video/video-poster-expected.txt [modify] https://crrev.com/ab6eb7c4a05309a35de41692f23067c50a8f8444/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt [modify] https://crrev.com/ab6eb7c4a05309a35de41692f23067c50a8f8444/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc [modify] https://crrev.com/ab6eb7c4a05309a35de41692f23067c50a8f8444/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.h [modify] https://crrev.com/ab6eb7c4a05309a35de41692f23067c50a8f8444/third_party/blink/renderer/core/paint/compositing/compositing_layer_assigner.cc [modify] https://crrev.com/ab6eb7c4a05309a35de41692f23067c50a8f8444/third_party/blink/renderer/core/paint/paint_layer.h
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c47dca193d62d073a0f3ba136f18b9f122cf9e16 commit c47dca193d62d073a0f3ba136f18b9f122cf9e16 Author: Ella Ge <eirage@chromium.org> Date: Fri Nov 16 20:08:37 2018 Revert "Disable video-poster.html on Mac bots" This reverts commit e2923c55319b49de75b1ed1b4bb4496120364fe3. Reason for revert: <revert the test expectations since original CL that cause failure is reverted> Original change's description: > Disable video-poster.html on Mac bots > > TBR=chrishtr@chromium.org > > Bug: 905860 , 900602 > Change-Id: I5d2a01010b4424ffa4312dfaf01e3ca0af24d182 > Reviewed-on: https://chromium-review.googlesource.com/c/1338570 > Reviewed-by: Ella Ge <eirage@chromium.org> > Commit-Queue: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608606} TBR=chrishtr@chromium.org,eirage@chromium.org Change-Id: Ibb383335e781e792898fdbce2f3eeb70639ad7a3 Bug: 905860 , 900602 Reviewed-on: https://chromium-review.googlesource.com/c/1340763 Reviewed-by: Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608914} [modify] https://crrev.com/c47dca193d62d073a0f3ba136f18b9f122cf9e16/third_party/WebKit/LayoutTests/TestExpectations
,
Nov 16
Cls landed here are reverted at #20 and #21. Also this is regressed in M70 and we're very close to M71 stable promotion, only one beta left. So rejecting merge to M71. Pls target fix for M72.
,
Nov 19
Re-landed as https://chromium-review.googlesource.com/c/chromium/src/+/1340875 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by woxxom@gmail.com
, Oct 31942 bytes
942 bytes View Download