New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 900599 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression

Blocking:
issue 899399



Sign in to add a comment

pixel_test consistently fails on Android FYI Release (Nexus 5)

Project Member Reported by riajiang@chromium.org, Oct 31

Issue description

* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_CanvasDisplayLinearRGBAccelerated2D
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_CanvasDisplayLinearRGBUnaccelerated2DGPUCompositing

consistently fails after this build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%205%29/10945

list 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20(Nexus%205)

suspecting https://chromium-review.googlesource.com/c/chromium/src/+/1306345 that changed pixel_test configs, ericrk@, could you please take a look to see if it's because of that? thanks!
 
Blocking: 899399
Components: Internals>GPU>Rasterization
Labels: -Type-Bug -Pri-3 Pri-1 Type-Bug-Regression
Raising to P1 because these bots must remain green. Eric, please tell me if it looks like there's something wrong here.

These are both expected changes, rebaslining now.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c238c411af417e59f2a1648fcb07ed1fe3697d8

commit 6c238c411af417e59f2a1648fcb07ed1fe3697d8
Author: Eric Karl <ericrk@chromium.org>
Date: Thu Nov 01 00:19:46 2018

Rebase Pixel_CanvasDisplayLinearRGB* tests due to GPU raster enablement

GPU raster caused slight differences around antialiased div edges.

TBR=kbr@chromium.org

Bug:  900599 
Change-Id: I2531fb642c50df820c5f4947d8670818217141c9
Reviewed-on: https://chromium-review.googlesource.com/c/1311835
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604460}
[modify] https://crrev.com/6c238c411af417e59f2a1648fcb07ed1fe3697d8/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/6c238c411af417e59f2a1648fcb07ed1fe3697d8/content/test/gpu/gpu_tests/pixel_test_pages.py

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9476fa3b516382ab67e3908044fd994f09b48ea

commit a9476fa3b516382ab67e3908044fd994f09b48ea
Author: Eric Karl <ericrk@chromium.org>
Date: Thu Nov 01 20:38:01 2018

Rebase Pixel_CanvasDisplayLinearRGB* tets for GPU raster enablement PT2

Follow up to:
https://chromium-review.googlesource.com/c/chromium/src/+/1311835

Re-enables tests after rebaselining.

TBR=kbr@chromium.org

Bug:  900599 
Change-Id: I4f3adb6adb934f73868c5f3e047d5ac4763e304a
Reviewed-on: https://chromium-review.googlesource.com/c/1313269
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604694}
[modify] https://crrev.com/a9476fa3b516382ab67e3908044fd994f09b48ea/content/test/gpu/gpu_tests/pixel_expectations.py

Status: Assigned (was: Untriaged)
ericrk: Any more work to do here?
Status: Fixed (was: Assigned)
Nope.

Sign in to add a comment