New issue
Advanced search Search tips

Issue 900585 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in v8::internal::PatternRewriter::VisitArrayLiteral

Project Member Reported by ClusterFuzz, Oct 31

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6541503827279872

Fuzzer: ochang_js_fuzzer
Job Type: linux_cfi_d8
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  v8::internal::PatternRewriter::VisitArrayLiteral
  v8::internal::PatternRewriter::VisitArrayLiteral
  v8::internal::PatternRewriter::RecurseIntoSubpattern
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_d8&range=57165:57166

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6541503827279872

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 31

Components: Blink>JavaScript>Parser
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 31

Labels: Test-Predator-Auto-Owner
Owner: verwa...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/70ce3103bd7e4b00f075533e2b30c8dc8dd02a1b ([parser] Remove RETURN_IF* part 15).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9bd6e601cb2312556ab91142ac0cbd1c9688994a

commit 9bd6e601cb2312556ab91142ac0cbd1c9688994a
Author: Toon Verwaest <verwaest@chromium.org>
Date: Wed Oct 31 18:39:42 2018

[parser] Don't rewrite if we're in error state

Bug:  chromium:900585 
Change-Id: I2f6045ce23af9a15baddc73127b0c4e3e514841c
Reviewed-on: https://chromium-review.googlesource.com/c/1310294
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57186}
[modify] https://crrev.com/9bd6e601cb2312556ab91142ac0cbd1c9688994a/src/parsing/pattern-rewriter.cc
[add] https://crrev.com/9bd6e601cb2312556ab91142ac0cbd1c9688994a/test/mjsunit/regress/regress-900585.js

Project Member

Comment 4 by ClusterFuzz, Nov 1

ClusterFuzz has detected this issue as fixed in range 57185:57186.

Detailed report: https://clusterfuzz.com/testcase?key=6541503827279872

Fuzzer: ochang_js_fuzzer
Job Type: linux_cfi_d8
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  v8::internal::PatternRewriter::VisitArrayLiteral
  v8::internal::PatternRewriter::VisitArrayLiteral
  v8::internal::PatternRewriter::RecurseIntoSubpattern
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_d8&range=57165:57166
Fixed: https://clusterfuzz.com/revisions?job=linux_cfi_d8&range=57185:57186

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6541503827279872

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Nov 1

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6541503827279872 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment