New issue
Advanced search Search tips

Issue 900580 link

Starred by 1 user
Status: Assigned
Owner:
drott@chromium.org
Cc:
smcgruer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

should FontVariationAxis be a double

Project Member Reported by xidac...@chromium.org, Oct 31 
While working on  crbug.com/900493 , I realized that FontVariationAxis is current a float. 

https://developer.mozilla.org/en-US/docs/Web/CSS/font-variation-settings says that the font variation settings value can be any javascript number, which means that it can be a double.

Comment 1 by drott@chromium.org, Nov 1 

When we pass it to Skia, it would still be a float at the moment, compare https://cs.chromium.org/chromium/src/third_party/skia/include/core/SkFontArguments.h?sq=package:chromium&g=0&l=16 
which is not to say we could consider changing that. There also have been some internal precision considerations for axis parameters in FreeType. 

However, IIRC to improve cache matches for variable font axis parameters, I think WebKit only uses fractional numbers for storing the variation axis values (citation needed :)).
►

Sign in to add a comment