New issue
Advanced search Search tips

Issue 900508 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 900506



Sign in to add a comment

Make WorkerClassicScriptLoader GarbageCollected

Project Member Reported by yhirano@chromium.org, Oct 31

Issue description

This is needed to make ThreadableLoaderClient garbage collected.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9f96bae8e579f19394008152fecb3b631341bc4

commit c9f96bae8e579f19394008152fecb3b631341bc4
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Nov 02 08:47:53 2018

Worker: Make WorkerClassicScriptLoader GC-managed

This is necessary for making ThreadableLoaderClient GC-managed and fixing memory
management issues around resource loading (see the issue for details).

Bug:  900508 
Change-Id: Ifd83b03fb80edd7cfd16034a80f3f08f122e9e88
Reviewed-on: https://chromium-review.googlesource.com/c/1314014
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604869}
[modify] https://crrev.com/c9f96bae8e579f19394008152fecb3b631341bc4/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/c9f96bae8e579f19394008152fecb3b631341bc4/third_party/blink/renderer/core/exported/web_shared_worker_impl.h
[modify] https://crrev.com/c9f96bae8e579f19394008152fecb3b631341bc4/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/c9f96bae8e579f19394008152fecb3b631341bc4/third_party/blink/renderer/core/workers/dedicated_worker.h
[modify] https://crrev.com/c9f96bae8e579f19394008152fecb3b631341bc4/third_party/blink/renderer/core/workers/worker_classic_script_loader.cc
[modify] https://crrev.com/c9f96bae8e579f19394008152fecb3b631341bc4/third_party/blink/renderer/core/workers/worker_classic_script_loader.h
[modify] https://crrev.com/c9f96bae8e579f19394008152fecb3b631341bc4/third_party/blink/renderer/core/workers/worker_global_scope.cc
[modify] https://crrev.com/c9f96bae8e579f19394008152fecb3b631341bc4/third_party/blink/renderer/core/workers/worker_global_scope.h
[modify] https://crrev.com/c9f96bae8e579f19394008152fecb3b631341bc4/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc
[modify] https://crrev.com/c9f96bae8e579f19394008152fecb3b631341bc4/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.h

Labels: M-72
Status: Fixed (was: Started)

Sign in to add a comment