(bulk comment)

To see the most recent code coverage report produced by the fuzz targets, use "latest" instead of the revision number in the URL to https://chromium-coverage.appspot.com/.

For example, https://chromium-coverage.appspot.com/reports/601457_fuzzers_only/linux/index.html needs to be changed to https://chromium-coverage.appspot.com/reports/latest_fuzzers_only/linux/index.html.

Assigning to cthomp@ as per go/fuzzathon-tasks.

Chris, I probably will have one more ask for you after landing that CL upgrading libpng. If we agree that we need to keep the "progressive_read" fuzz target, could you please move it to third_party/libpng/? I would not mind if you do it in the same CL, up to you, let's just agree with scroggo@ that we really need it.

Would we instead want to upstream it to libpng (and meanwhile maintain a patch locally for it)?

You're right, that would be the best!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dceca3da0b3318ae4074592a7d517689c4e1335

commit 5dceca3da0b3318ae4074592a7d517689c4e1335
Author: Christopher Thompson <cthomp@chromium.org>
Date: Sat Nov 10 00:16:25 2018

Update libpng to v1.6.35 and use the upstream fuzzer

The latest release of libpng has an improved fuzzer (as part of its
oss-fuzz integration). This CL rolls //third_party/libpng to the latest
v1.6.35 and adds a target to the BUILD.gn to setup and use the included
libpng fuzz target.

This leaves the existing progressive read fuzz target in
testing/libfuzzer/fuzzers/ (the upstream fuzzer does not currently
support this), but replaces the normal read fuzzer.

This also adds a patch file for the change in https://crrev.com/c/1014027
for future version rolls.

Bug: 900480
Change-Id: Iec93c963fe5214e519f9e5d1a9414059b8f596c8
Reviewed-on: https://chromium-review.googlesource.com/c/1327237
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607047}
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/testing/libfuzzer/fuzzers/BUILD.gn
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/testing/libfuzzer/fuzzers/libpng_read_fuzzer.cc
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/BUILD.gn
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/README
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/README.chromium
[add] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/contrib/README.txt
[add] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/contrib/oss-fuzz/README.txt
[add] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/contrib/oss-fuzz/libpng_read_fuzzer.cc
[add] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/contrib/oss-fuzz/png.dict
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/intel/filter_sse2_intrinsics.c
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/mips/filter_msa_intrinsics.c
[add] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/patches/0001-chunkerror.patch
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/patches/README
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/png.c
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/png.h
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngconf.h
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngget.c
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pnginfo.h
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngpread.c
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngpriv.h
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngread.c
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngrio.c
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngrtran.c
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngrutil.c
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngset.c
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngstruct.h
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngtest.c
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngtrans.c
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngwio.c
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngwrite.c
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngwtran.c
[modify] https://crrev.com/5dceca3da0b3318ae4074592a7d517689c4e1335/third_party/libpng/pngwutil.c