New issue
Advanced search Search tips

Issue 900469 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 31
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

virtual/.../iframe-print.html in webkit_layout_tests failing on chromium.win/WebKit Win10

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Oct 31

Issue description

Cc: -horo@google.com horo@chromium.org
Owner: mstensho@chromium.org
Status: Assigned (was: Available)
mstensho@
Could you please take a look?
Got disabled here (by another Sheriff?):
https://chromium-review.googlesource.com/c/1308939
Labels: -Sheriff-Chromium
Removing from the sheriff queue since the test is now disabled.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a40bf9236377fc8caa9c8f0ef5e82dbde7dd09e9

commit a40bf9236377fc8caa9c8f0ef5e82dbde7dd09e9
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Wed Oct 31 17:59:18 2018

Rebaseline printing/iframe-print.html and remove failure expectations.

It used to fail on Windows. The rebaseline tool shuffled expectations
around quite a bit (I expected only Windows to change), but I guess
that's right.

Bug: 591500,  900469 
Change-Id: Id894f5637a52b9623990b7a618447490c80d137a
Reviewed-on: https://chromium-review.googlesource.com/c/1309653
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604327}
[modify] https://crrev.com/a40bf9236377fc8caa9c8f0ef5e82dbde7dd09e9/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/a40bf9236377fc8caa9c8f0ef5e82dbde7dd09e9/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/printing/iframe-print-expected.png
[rename] https://crrev.com/a40bf9236377fc8caa9c8f0ef5e82dbde7dd09e9/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/layout_ng_experimental/printing/iframe-print-expected.png
[delete] https://crrev.com/4b9bcd702e865b76d5ed453dd8d9aa73479288eb/third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/iframe-print-expected.png
[delete] https://crrev.com/4b9bcd702e865b76d5ed453dd8d9aa73479288eb/third_party/WebKit/LayoutTests/platform/win/printing/iframe-print-expected.png
[add] https://crrev.com/a40bf9236377fc8caa9c8f0ef5e82dbde7dd09e9/third_party/WebKit/LayoutTests/platform/win7/virtual/layout_ng_experimental/printing/iframe-print-expected.png

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31

Status: Fixed (was: Assigned)

Sign in to add a comment