New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 900459 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Broken scrolling behavior on certain websites

Project Member Reported by wac@google.com, Oct 31

Issue description

Chrome Version       : 72.0.3595.0
OS Version: OS X 10.13.6
URLs (if applicable) : https://www.twitch.tv/popout/northernlion/chat?popout=
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari: OK
    Firefox: -
    IE/Edge: -

What steps will reproduce the problem?
1. Visit any chat URL with some traffic, wait for chats to scroll in...

What is the expected result?
  The input box should stay on the bottom of the window and the portion contain chatting messages should scroll.

What happens instead of that?
  The input box is pushed off the bottom of the window.

Please provide any additional information below. Attach a screenshot if
possible.
Before: https://screenshot.googleplex.com/BxUReuULreB
After: https://screenshot.googleplex.com/0VcDm7kFsDM

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3595.0 Safari/537.36



 
Same behavior repros in dev-channel 72.0.3595.2
Does not repro in beta-channel 71.0.3578.20
Repros in canary 72.0.3596.0
Bisected to r595225 = f033b7d2fc1c1a44006a9c30afc864abc9e7571b = https://crrev.com/c/1252682 by cbiesinger@chromium.org
"[css-flexbox] Apply min-height: auto to nested flexboxes again"
Landed in 71.0.3565.0
Labels: Needs-Triage-M72 Needs-Bisect
Does it still repro on 72.0.3596.0? I reverted a patch in  bug 899161  that caused wide-spread scrolling issues. Though #3 seems to indicate otherwise...
#3 indicates a different CL not related to  bug 899161 .
Still repros in 72.0.3596.0.
Components: Blink>Layout
mine is still doing the same thing. The input chat box is pushed off the bottom of the window isntead of being able to scroll
. While watching twitch channels using latest build Google Chrome is up to date
Version 72.0.3596.0 (Official Build) canary (64-bit)
 Same issues as above-- while on www.twtich.tv and any live channel my chat does not scroll at all. As more messages come through, they eventually fill up where the chat box goes, forcing the box to type in messages itself to be pushed off screen, and any new text to not appear as its "below" the bottom of the screen.

using latest build Google Chrome is up to date
Version 72.0.3596.0 (Official Build) canary (64-bit)



dc67d394364ac86e2a7a95417839abff.png
54.2 KB View Download
e9eb5d528d8ea72d1f2e978697eea454.png
74.6 KB View Download
Cc: bokan@chromium.org
Owner: cbiesin...@chromium.org
cbiesinger@, this regression looks to be a result of your CL in #3, ptal.
Cc: jbanavatu@chromium.org
Labels: -Pri-3 -Needs-Bisect RegressedIn-72 Target-72 M-72 FoundIn-72 hasbisect OS-Linux OS-Windows Pri-1
Status: Assigned (was: Unconfirmed)
Tested in chrome reported version #72.0.3595.0, Latest canary #72.0.3597.0 on Linux Debian Rodete, Win 10,Mac OS 10.13.6. Able to reproduce the issue.

Below are the Bisect Details:

Unable to provide per revision bisect for below regression range due to below exception:
RuntimeError: We don't have enough builds to bisect. revlist: []

Using the chromium bisect providing the results,
Good Build: 72.0.3588.0
Bad Build: 72.0.3589.0

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/a7dbc108d44baa4228ce37bfe6cfcb1b8990cf71..2fa238e3ac6f79fe0e11c8a1065fed41b4ac4a1e

From the CL above, suspecting -https://chromium.googlesource.com/chromium/src/+/155c1f2bf45369bc7130c89b88c75c2d3c915410 

@ cbiesinger: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Reviewed-on: https://chromium-review.googlesource.com/c/1269235

Thanks!
 Issue 900831  has been merged into this issue.
Cc: dholb...@gmail.com
Yes, this was caused by my change.
This div here:
<div class="chat-room__content tw-border-l tw-c-background-alt-2 tw-c-text-base tw-flex tw-flex-column tw-flex-grow-1 tw-flex-nowrap tw-full-height tw-relative


Should have a min-height: 0;

I expected Firefox to have the same behavior as us, but for some reason they do not compute the min-height of that div to the same thing... dholbert, do you know why?

At any rate, this should be fixed by Twitch on their end.
Oh, hm... I wonder if this is broken due to  bug 784059 , which interacts somewhat poorly with my change... let me test that...
Ah yes. Fixing that bug will fix Twitch here. Let me see if I can accelerate landing that fix.
Labels: allpublic
Labels: ReleaseBlock-Stable
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d519ce9b1818139c082ff339c7c5d3af18b1baa7

commit d519ce9b1818139c082ff339c7c5d3af18b1baa7
Author: Christian Biesinger <cbiesinger@chromium.org>
Date: Tue Nov 06 01:18:25 2018

Reland "[css-flex] Update to newer spec about definite flex item sizes"

This reverts commit 82ef33772f758883cda6379610b24f27e7ff3bbe.

Implements this change:
https://github.com/w3c/csswg-drafts/commit/5b5db39d21f3658ae2f4d7992daaf822aca178d8

external/wpt/css/css-flexbox/percentage-heights-003.html ostensibly tests
this, but I don't think the test is correct (and we don't pass it)

To fix the regression from the original change, I updated the devtools code
to specify a flex-basis of auto. It previously defaulted to 0%, which
used to be resolved to auto, but with this change resolves to 0px,
which is not what the code wants.

TESTED=css3/flexbox/definite-main-size.html

Bug:  784059 , 900459 
Change-Id: I773877f34b281dd6bfe4ac02b9aad90451c3acf9
Reviewed-on: https://chromium-review.googlesource.com/c/1247184
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605553}
[modify] https://crrev.com/d519ce9b1818139c082ff339c7c5d3af18b1baa7/third_party/WebKit/LayoutTests/css3/flexbox/definite-main-size.html
[modify] https://crrev.com/d519ce9b1818139c082ff339c7c5d3af18b1baa7/third_party/blink/renderer/core/layout/layout_flexible_box.cc
[modify] https://crrev.com/d519ce9b1818139c082ff339c7c5d3af18b1baa7/third_party/blink/renderer/devtools/front_end/animation/animationTimeline.css
[modify] https://crrev.com/d519ce9b1818139c082ff339c7c5d3af18b1baa7/third_party/blink/renderer/devtools/front_end/coverage/coverageView.css
[modify] https://crrev.com/d519ce9b1818139c082ff339c7c5d3af18b1baa7/third_party/blink/renderer/devtools/front_end/devtools_compatibility.js
[modify] https://crrev.com/d519ce9b1818139c082ff339c7c5d3af18b1baa7/third_party/blink/renderer/devtools/front_end/ui/treeoutline.css

Status: Fixed (was: Assigned)
This should be fixed in the next canary.

Sign in to add a comment