Separate TextureRef class from video_decode_accelerator_unittest_helpers |
|||
Issue descriptionmedia::test::TextureRef is traditionally used by VDA unittest. However, TextureRef needs to be used by VEA unittest too, see the CL to enable VEA unittest to test DMAbuf-backed video frame [1]. Because media::TextureRef is in video_decode_accelerator_unittest_helpers.h. It may be misleading to include the header file in VEA unittest. Therefore, media::test::TextureRef should be separated from the header file and then in somewhere like media/gpu/test/texture_ref.h [1] https://chromium-review.googlesource.com/c/chromium/src/+/1295636 [2] https://cs.chromium.org/chromium/src/media/gpu/test/video_decode_accelerator_unittest_helpers.h
,
Oct 31
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72cea2dc662c5982e23c5e8f65abb448ede67d6f commit 72cea2dc662c5982e23c5e8f65abb448ede67d6f Author: David Staessens <dstaessens@chromium.org> Date: Thu Nov 01 02:07:05 2018 media/gpu/test: Move TextureRef class out of video_decode_accelerator_unittest_helpers. The TextureRef class will also be used by video encode tests, so it doesn't make sense to keep it in a decode-specific helper file. No code was added or changed, this CL is only moving the class to a separate file. TEST=ran VDA unittests on eve BUG= 900433 Change-Id: Id104701554ea0bd1e12c10221346e946ff1b9c50 Reviewed-on: https://chromium-review.googlesource.com/c/1309381 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604487} [modify] https://crrev.com/72cea2dc662c5982e23c5e8f65abb448ede67d6f/media/gpu/BUILD.gn [modify] https://crrev.com/72cea2dc662c5982e23c5e8f65abb448ede67d6f/media/gpu/test/rendering_helper.cc [add] https://crrev.com/72cea2dc662c5982e23c5e8f65abb448ede67d6f/media/gpu/test/texture_ref.cc [add] https://crrev.com/72cea2dc662c5982e23c5e8f65abb448ede67d6f/media/gpu/test/texture_ref.h [modify] https://crrev.com/72cea2dc662c5982e23c5e8f65abb448ede67d6f/media/gpu/test/video_decode_accelerator_unittest_helpers.cc [modify] https://crrev.com/72cea2dc662c5982e23c5e8f65abb448ede67d6f/media/gpu/test/video_decode_accelerator_unittest_helpers.h [modify] https://crrev.com/72cea2dc662c5982e23c5e8f65abb448ede67d6f/media/gpu/video_decode_accelerator_unittest.cc
,
Nov 1
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dstaessens@google.com
, Oct 31