New issue
Advanced search Search tips

Issue 900432 link

Starred by 3 users
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Oct 31
Cc:
pfeldman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization is flaky

Project Member Reported by tbansal@chromium.org, Oct 31 
Example runs:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11030

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11029

Stack trace:
Expected equality of these values:
  "[OK]"
  result
    Which is: "[FAILED] Timeout exceeded: 20 sec"
Stack trace:
#0 0x000007f17f60 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x000007f17b3d testing::internal::AssertHelper::operator=()
#2 0x000006daee5a _ZN12_GLOBAL__N_128DispatchOnTestSuiteSkipCheckIJEEEvP14DevToolsWindowPKcDpT_
#3 0x000006da3b5f _ZN12_GLOBAL__N_119DispatchOnTestSuiteIJEEEvP14DevToolsWindowPKcDpT_
#4 0x000006da45f7 WorkerDevToolsSanityTest_PauseInSharedWorkerInitialization_Test::RunTestOnMainThread()

Comment 1 by tbansal@chromium.org, Oct 31

Labels: Sheriff-Chromium
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a58614ddd3ab38b6482c5600d9d2153ecb73bb33

commit a58614ddd3ab38b6482c5600d9d2153ecb73bb33
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Oct 31 01:01:25 2018

Disable WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization on Linux

Change-Id: Ibac0faa988dfa05b727967251d0f51cfe0b474d1
Bug:  900432 
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
TBR: dgozman@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1309322
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604089}
[modify] https://crrev.com/a58614ddd3ab38b6482c5600d9d2153ecb73bb33/chrome/browser/devtools/devtools_sanity_browsertest.cc

Comment 3 by horo@chromium.org, Oct 31 

 Issue 900388  has been merged into this issue.

Comment 4 by horo@chromium.org, Oct 31

Cc: pfeldman@chromium.org
Labels: OS-Chrome OS-Mac OS-Windows
Owner: dgozman@chromium.org
Summary: WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization is flaky (was: WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization is flaky on Linux CFI)
dgozman@chromium.org
Could you please handle this?

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization

Comment 5 by horo@chromium.org, Oct 31

Labels: -Sheriff-Chromium
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc13071370ae8904ae6d83e49174803a4fc5e14c

commit dc13071370ae8904ae6d83e49174803a4fc5e14c
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Oct 31 16:56:57 2018

[DevTools] Fix a race when inspecting shared/service worker

When pausing on initialization, we issue Debugger.enable
immediately followed by Debugger.pause and expect the pause to happen.

Because Debugger.pause can interrupt JS, it may actually run before
Debugger.enable on the backend. That makes pause noop, and we never
pause.

The solution is to await for Debugger.enable before asking to pause.

Bug: 775132,  900432 
Change-Id: Ic2f504875b98312839235c6e32a10403757444f2
Reviewed-on: https://chromium-review.googlesource.com/c/1309213
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604299}
[modify] https://crrev.com/dc13071370ae8904ae6d83e49174803a4fc5e14c/third_party/blink/renderer/devtools/front_end/sdk/ChildTargetManager.js
[modify] https://crrev.com/dc13071370ae8904ae6d83e49174803a4fc5e14c/third_party/blink/renderer/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/dc13071370ae8904ae6d83e49174803a4fc5e14c/third_party/blink/renderer/devtools/front_end/worker_main/WorkerMain.js
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e927c49ebe45ef2d3f7194b40fd75234b5bccd73

commit e927c49ebe45ef2d3f7194b40fd75234b5bccd73
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Oct 31 17:08:15 2018

Revert "Disable WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization on Linux"

This reverts commit a58614ddd3ab38b6482c5600d9d2153ecb73bb33.

Reason for revert: the issue should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1309213

Original change's description:
> Disable WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization on Linux
> 
> Change-Id: Ibac0faa988dfa05b727967251d0f51cfe0b474d1
> Bug:  900432 
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> TBR: dgozman@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/1309322
> Commit-Queue: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604089}

TBR=dgozman@chromium.org,tbansal@chromium.org

Change-Id: Ib776370c42fffc4c44ddec9eca10c8093c6db01b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  900432 
Reviewed-on: https://chromium-review.googlesource.com/c/1310355
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604302}
[modify] https://crrev.com/e927c49ebe45ef2d3f7194b40fd75234b5bccd73/chrome/browser/devtools/devtools_sanity_browsertest.cc

Comment 8 by dgozman@chromium.org, Oct 31

Status: Fixed (was: Untriaged)
►

Sign in to add a comment