Flakiness in mix-blend-mode-isolated-group-1 and mix-blend-mode-isolated-group-3 |
|||
Issue descriptionHi. While rebaselining the layout tests in a CL, I noticed that I was getting inconsistent results between runs of the blink_tool script and the differences involved mix-blend-mode-isolated-group-1 and mix-blend-mode-isolated-group-3 files. Both https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=mix-blend-mode-isolated-group-1 and https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=mix-blend-mode-isolated-group-3 seem to suggest that these tests are flaky. masonfreed@ CCing you because pdr@ suggested that https://chromium.googlesource.com/chromium/src/+/c41b2d08296c7d720343f716641e40c9c2f68ad0 might be the culprit.
,
Oct 31
Likely another flaky test with --enable-display-compositor-pixel-dump
,
Oct 31
Hmm, while it's definitely possible that this was caused by my CL, it doesn't really fit the pattern of the rest of the failing/flaky tests. Usually they have some type of animation or delay involved, while this looks (maybe I missed it?) like just a pure paint test. Feel free to comment them out on TestExpectations and add them to the group at the top, for sure. I'm just wondering if maybe they were flaky before? (I still don't know how to read the flakiness dashboard. It doesn't look like it goes back before last week.
,
Oct 31
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18e93ce4389f39e6ff4ee299893786ef6ec2bf2a commit 18e93ce4389f39e6ff4ee299893786ef6ec2bf2a Author: Andres Calderon Jaramillo <andrescj@chromium.org> Date: Mon Nov 05 19:29:26 2018 blink: Disable flaky mix-blend-mode-isolated-group-{1, 3} on Mac. This CL disables css3/blending/mix-blend-mode-isolated-group-1.html and css3/blending/mix-blend-mode-isolated-group-3.html on Mac. Bug: 900431 Change-Id: I4b21aadb11ff91182b495ffe0959e9c8f5a7184c Reviewed-on: https://chromium-review.googlesource.com/c/1312680 Reviewed-by: Dmitry Titov <dimich@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#605412} [modify] https://crrev.com/18e93ce4389f39e6ff4ee299893786ef6ec2bf2a/third_party/WebKit/LayoutTests/TestExpectations |
|||
►
Sign in to add a comment |
|||
Comment 1 by andrescj@chromium.org
, Oct 31