New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 900429 link

Starred by 2 users
Status: Started
Owner:
nhiroki@chromium.org
Cc:
falken@chromium.org
█ asamidoi@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 680046



Sign in to add a comment

WorkerModuleTreeClient should terminate a worker thread when module loading fails

Project Member Reported by nhiroki@chromium.org, Oct 31 
In the current impl, when module loading fails, WorkerModuleTreeClient throws an exception. This is not enough. WorkerModuleTreeClient should explicitly request to stop the worker thread. Probably WorkerModuleTreeClient just needs to call WorkerGlobalScope::close() after throwing the exception.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fa1b4bbf82bfb9920b68b8077678084fd31ea5a

commit 0fa1b4bbf82bfb9920b68b8077678084fd31ea5a
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Nov 01 09:31:15 2018

ServiceWorker: Avoid specific error handling from DidCloseWorkerGlobalScope()

ServiceWorkerGlobalScopeProxy::DidCloseWorkerGlobalScope() is called after
WorkerGlobalScope::close() to report the event somewhere. close() is a common
way to stop worker global scope, so its report function should also be common.
Otherwise, it's difficult to use close() for general purposes.

For that, this CL avoids error handling specific to failures on loading installed
scripts from DidCloseWorkerGlobalScope().

Change-Id: Icd36425f33727c0ea703471a7b376e33e9663784
Bug: 900429
Reviewed-on: https://chromium-review.googlesource.com/c/1309558
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604536}
[modify] https://crrev.com/0fa1b4bbf82bfb9920b68b8077678084fd31ea5a/third_party/blink/renderer/core/workers/worker_reporting_proxy.h
[modify] https://crrev.com/0fa1b4bbf82bfb9920b68b8077678084fd31ea5a/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
[modify] https://crrev.com/0fa1b4bbf82bfb9920b68b8077678084fd31ea5a/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
[modify] https://crrev.com/0fa1b4bbf82bfb9920b68b8077678084fd31ea5a/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h
►

Sign in to add a comment