New issue
Advanced search Search tips

Issue 900428 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 7
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug

Blocking:
issue 899348



Sign in to add a comment

Migrate to use Scenic as an input source

Project Member Reported by kmarshall@chromium.org, Oct 31

Issue description

The switch to Views V2 involves deprecation of InputConnection. We should rewrite our input handling to receive input events from Scenic instead.

 
I have a local client which supports keyboard and touch events, but pointer event support is not yet available. See SCN-1069 .
 Issue 881591  has been merged into this issue.
Blocking: 899348
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68f78e871d833efcd772dd7c57ab0ab94e292ba0

commit 68f78e871d833efcd772dd7c57ab0ab94e292ba0
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Nov 01 23:51:11 2018

Fuchsia: Add support for receiving input events from Scenic.

ViewsV2 eschews InputConnection in favor of using Scenic for delivering
input events to applications.

This adds input event handling for pointer and touch events via
ScenicSession.

Keyboard events are already being delivered by the ImeService and
are handled by InputMethodKeyboardControllerFuchsia, so no changes are
needed for receiving keyboard inputs.

      "tiles --input_path=new" switches.

Test: manual test against both "tiles --input_path=old" and
Bug:  900428 
Change-Id: I8ba2e0c7d35d0dd9d52ef54379d6d693bd9e82d5
Reviewed-on: https://chromium-review.googlesource.com/c/1308910
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604758}
[modify] https://crrev.com/68f78e871d833efcd772dd7c57ab0ab94e292ba0/ui/ozone/platform/scenic/scenic_window.cc
[modify] https://crrev.com/68f78e871d833efcd772dd7c57ab0ab94e292ba0/ui/ozone/platform/scenic/scenic_window.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fed51e86341b83a8ac27292877c6f9841e642ba4

commit fed51e86341b83a8ac27292877c6f9841e642ba4
Author: Wez <wez@chromium.org>
Date: Thu Jan 03 00:48:28 2019

[Fuchsia] Remove legacy InputConnection path for receiving user input.

User input is now received via the Scenic session, so remove the legacy
InputConnection path for those events.

Bug:  900428 
Change-Id: Ifcbb04c52cf517fe8f472854d5736625ff1a87d5
Reviewed-on: https://chromium-review.googlesource.com/c/1393705
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619547}
[modify] https://crrev.com/fed51e86341b83a8ac27292877c6f9841e642ba4/ui/ozone/platform/scenic/scenic_window.cc
[modify] https://crrev.com/fed51e86341b83a8ac27292877c6f9841e642ba4/ui/ozone/platform/scenic/scenic_window.h

Status: Verified (was: Assigned)

Sign in to add a comment