New issue
Advanced search Search tips

Issue 900422 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Clip the child surface damage rect to the clip rect in surface aggregation

Project Member Reported by magchen@chromium.org, Oct 30

Issue description

This is an optimization to reduce the damage rect in surface aggregation.

When clipping is on, we can reduce the child surface damage rect by applying clipping.

This issue can be found DC layer overlay processor. Sometimes we found the damage rect is bigger than the clip rect when processing underlay because the damage rect not clipped. This can be solved with the change in surface aggregation.

 
Cc: danakj@chromium.org weiliangc@chromium.org sunn...@chromium.org enne@chromium.org
Components: Internals>Compositing
Labels: -Pri-3 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/decd40e621cc77a2393304202e0a4b2b79fd74f5

commit decd40e621cc77a2393304202e0a4b2b79fd74f5
Author: Maggie Chen <magchen@chromium.org>
Date: Mon Nov 05 01:17:51 2018

Clip the damage rect of the child surface if clipping is on

This is an optimization to reduce the size of damage rect in surface aggregation.
When clipping is on, we should clip the child surface damage rects before adding
them to the parent damage rect.

BUG= 900422 

Change-Id: Ia85f1d86bf4ba13ac66167c5de04c657d66d175c
Reviewed-on: https://chromium-review.googlesource.com/c/1309318
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605217}
[modify] https://crrev.com/decd40e621cc77a2393304202e0a4b2b79fd74f5/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/decd40e621cc77a2393304202e0a4b2b79fd74f5/components/viz/service/display/surface_aggregator_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment