[Fuchsia] Add SkFontMgr implementation for Fuchsia is Skia and use it in chromium |
|||
Issue descriptionCurrently we have two SkFontMgr implementations for Fuchsia: Chromium: https://codesearch.chromium.org/chromium/src/skia/ext/fontmgr_fuchsia.cc?sq=package:chromium&dr=CSs&g=0 Topaz: https://fuchsia.googlesource.com/topaz/+/HEAD/runtime/flutter_runner/fuchsia_font_manager.cc The topaz version is more up-to-date with the service interface, particularly it has proper implementation of onMatchFamilyStyleCharacter() and it supports font collections. Ideally we should have just one implementation that would be used both in chromium and in Flutter. I suggest moving the impl from Topaz to Skia repo and then start using it chromium, then skia::FuchsiaFontManager can be removed from chromium
,
Nov 28
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a02ef2bc6c5d674106707fe96cebe29e46aea8e6 commit a02ef2bc6c5d674106707fe96cebe29e46aea8e6 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Tue Dec 11 19:32:51 2018 [Fuchsia] Use SkFontMgr_Fuchsia instead of FuchsiaFontManager Skia now contains SkFontMgr implementation for Fuchsia. Updated SkFontMgr::Factory() to use it and removed the old implementation from //skia/ext. The new implementation adds some features that were previously missing, particularly font collection and character matching. Bug: 900395 Change-Id: I545bb33b20d34e3ab02b04f6a1b705e5420d65d7 Reviewed-on: https://chromium-review.googlesource.com/c/1370500 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615626} [modify] https://crrev.com/a02ef2bc6c5d674106707fe96cebe29e46aea8e6/skia/BUILD.gn [modify] https://crrev.com/a02ef2bc6c5d674106707fe96cebe29e46aea8e6/skia/ext/fontmgr_default_fuchsia.cc [delete] https://crrev.com/947e0b191b9c892277d5e8bf9988d2f84067349c/skia/ext/fontmgr_fuchsia.cc [delete] https://crrev.com/947e0b191b9c892277d5e8bf9988d2f84067349c/skia/ext/fontmgr_fuchsia.h [modify] https://crrev.com/a02ef2bc6c5d674106707fe96cebe29e46aea8e6/skia/ext/fontmgr_fuchsia_unittest.cc
,
Jan 15
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sergeyu@chromium.org
, Oct 30