New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 900378 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Navi] rename "sign in" button to "continue"

Project Member Reported by scottchen@google.com, Oct 30

Issue description

rename "sign in" button in the signin-view to say "continue" instead.
 
Owner: namratakannan@chromium.org
Status: Assigned (was: Available)
namratakannan@ can you go over the mock to see if the text on the signin-view is satisfactory, and provide a link to the mock with the desired text?
Status: Started (was: Assigned)
Owner: scottchen@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cd7b168a676f1c850b1103a660f88db064bb2bd

commit 7cd7b168a676f1c850b1103a660f88db064bb2bd
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Nov 02 00:48:12 2018

Nux Onboarding: change sign-in page to match mock
- Update string
- fix text not centering on small screens.

Bug:  900378 
Change-Id: Iad5640c486974c1e515df9f2519e828098d900da
Reviewed-on: https://chromium-review.googlesource.com/c/1308909
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604780}
[modify] https://crrev.com/7cd7b168a676f1c850b1103a660f88db064bb2bd/chrome/app/onboarding_welcome_strings.grdp
[modify] https://crrev.com/7cd7b168a676f1c850b1103a660f88db064bb2bd/chrome/browser/resources/welcome/onboarding_welcome/shared/splash_pages_shared_css.html

Status: Fixed (was: Started)

Sign in to add a comment