New issue
Advanced search Search tips

Issue 900356 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 14
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

virtual/threaded/animations/animationworklet/worklet-animation-style-update.html is flaky on Windows

Project Member Reported by tbansal@chromium.org, Oct 30

Issue description

Components: Blink>Animation
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bf55d6a0b999b7b810151990fb5bf87e72d880e

commit 1bf55d6a0b999b7b810151990fb5bf87e72d880e
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Oct 31 00:25:56 2018

Update test expectations for worklet-animation-style-update.html

Change-Id: I4c4f853fa45e146cfaaacd18ebf5e8dc5a35c944
Bug:  900356 
TBR: zmin@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1309074
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604077}
[modify] https://crrev.com/1bf55d6a0b999b7b810151990fb5bf87e72d880e/third_party/WebKit/LayoutTests/TestExpectations

Status: Available (was: Untriaged)
Labels: Test-Layout
Components: -Blink>Animation Internals>Compositing>Animation
Labels: -Test-Layout Hotlist-Experimental Hotlist-AnimationWorklet
Owner: yigu@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be34ad2a2a42e8a4a89d40b15f8f7b7c3ab42fed

commit be34ad2a2a42e8a4a89d40b15f8f7b7c3ab42fed
Author: Yi Gu <yigu@chromium.org>
Date: Tue Nov 13 18:24:26 2018

[animation worklet] Delete duplicated layout test

Previously worklet-animation-style-update.html used runChecksWithRAF to
test the output because it was the only way to check getComputedStyle.
Now that getComputedStyle is supported via peeking via main thread and
the behavior has been tested in animator-animate.html, we no longer
need this test.

Bug:  900356 
Change-Id: I104f271c562c6718c664dc1de264018f928eb546
Reviewed-on: https://chromium-review.googlesource.com/c/1319511
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607662}
[modify] https://crrev.com/be34ad2a2a42e8a4a89d40b15f8f7b7c3ab42fed/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/ca2f043a37f284107b2d8f82d925aebc39d98237/third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-style-update-expected.txt
[delete] https://crrev.com/ca2f043a37f284107b2d8f82d925aebc39d98237/third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-style-update.html

Status: Fixed (was: Started)

Sign in to add a comment