New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 900351 link

Starred by 1 user

[PIN Settings]Unable to set PIN from the virtual keyboard.

Project Member Reported by abod...@chromium.org, Oct 30

Issue description

Chrome OS 11151.17.0, 71.0.3578.27 

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(0)Make sure that device is in tabletview 
(1)Click on add user and Enter username and password
(2)Try to enter PIN from the virtual keyboard at Choose pin screen
(3)

Expected Result:

Actual Result:
Unable to set PIN from the virtual keyboard.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)
Cc: yhanada@chromium.org shuchen@chromium.org
Owner: yhanada@chromium.org
I think this issue should be called "virtual keyboard does not work for first-run UI (and Captive portal networks too)".
My speculation is that the First Run UI is a part of Login/OOBE UI, which is started under Sign-In user and continues into user session.
But Virtual keyboard is popped up when user has already logged in, so active user == real user, and it is likely attached to real user profile.

So events are not passed from user UI to an incognito UI.

This also likely breaks Captive portal configuration, which also happens in incognito UI within user session.
Cc: osh...@chromium.org
Cc: afakhry@chromium.org
Cc: atwilson@chromium.org
+Drew for (possible) captive portal issues in #2. FYI.
Cc: steve...@chromium.org
Cc: zalcorn@chromium.org
Owner: goog...@chromium.org
In progress, Just want to double-check, whether this is a release blocking issue?

Owner: shuchen@chromium.org
The root cause it's on OOBE. When user login successful.
Then confirm "yes" to next "setting pin" page.

Input method framework doesn't fire the "onFocus" to IME.
Since IME doesn't hold the "context" of the current input box.
IME can't do anything of the current input box.

On the same page, if you enable "a11y keyboard", then IMF fire "onFocus" event 
to IME. Then virtual keyboard works correctly now.
Even you uncheck "a11y keyboard" now. The normal virtual keyboard still works
well.

shuchen@ and alemate@ Could you investigate why IMF doesn't fire the "onFocus" event.



Note that last time I tried, I couldn't close the VK after opening it. Then it can become the serious issue because VK covers the numpad, so I can't set PIN number.
Please check whether VK can close or not. If it can close, I don't think this is critical.
This issue may shares the same root cause as  issue 900124 , which has been fixed by http://crrev.com/c/1317010.

I cannot repro this with the fix. So please verify it in the next R71 build.

Status: Fixed (was: Assigned)
Which 71 build should I see this fix in? I'm seeing it in 71.0.3578.39
Labels: -Pri-2 Pri-1
Status: Assigned (was: Fixed)
Confirmed that http://crrev.com/c/1317010 should be in 71.0.3578.39, but the bug still exists here. 
Can we suppress the VK on the PIN screen entirely until we can get VK working well with it? As per #10, this becomes really janky because you can't easily close the VK once it pops up.
I just built M71 ToT locally, and it still does not work for me.
Will verify and confirm later today.

I'm wondering why the pri is raised at #14?

I flash M71.0.3578.27 version.

At the first time. Powerwash then setup account. It doesn't show VK on pin settings page.
The second time. Powerwash then setup account. It shows VK on the pin settings page. And VK deosn't work.

On 72.0.3606.0 The bug still repro.
Flash latest M72.3606.0 version in Scarlet pad , after powerwash, log on with private gmail account, can show vk on the pin setting page, but vk doesn't work;
Cc: omrilio@chromium.org
re: priority The user experience is very bad here if the user taps the PIN input field - they are unable to proceed unless they figure out to click outside of the input field.

We need a fix here for Meowth, either to allow VK input/dismissal or to prevent the VK from appearing on this screen at all.

I'm okay with either option, whichever is simpler and less risky to merge.
The only way we know of to prevent the VK is to make the input field
uneditable and force the onscreen pin input.  Of course, this will also
mean the physical kb won't work, unless you add JS to cover that.

Otherwise, we are working on the VK bug, and it appears that the first fix
was only part of the problem, so we're looking into the current cause.  The
VK needs to be fixed in any case.

We're close to m71 stable, so I'll discuss with the team.

On Tue, Nov 13, 2018, 3:34 AM zalcorn via monorail <
monorail+v2.779798257@chromium.org wrote:
I thought the PIN screen is only shown in Tablets mode, which means no physical keyboard is attached.

zalcorn@, can you please confirm whether the solution of making the PIN input field as uneditable is acceptable? Thanks.
Labels: Merge-Request-71
Requesting merge for #21
alemate@, thanks for disables the pin input field.

I suspect that the PIN screen has weird profile configurations so that the VK web contents is running with profile A while the IME extension background page is running with profile B.

I'm trying to debug into the issue and verify my idea.

alemate@, do you know whether it is possible to debug PIN screen with cros_on_linux?
Thanks!


Yep I tried out alemate@'s CL yesterday and it's a workable fix for now.
Re #24: I specifically said this in my first comment.

First run UI is an incognito UI (i.e. it is run from sign-in user), but IME is a part of user session.

I believe that all in-session incognito UI is broken. Like captive portal authorization.
Project Member

Comment 27 by sheriffbot@chromium.org, Nov 14

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Merge Approved for ChromeOS M71
Project Member

Comment 29 by sheriffbot@chromium.org, Nov 19

Cc: alemate@chromium.org geo...@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-71 Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/bd534b9d0010e2cee370022fe6e6982ef3357450

Commit: bd534b9d0010e2cee370022fe6e6982ef3357450
Author: alemate@chromium.org
Commiter: alemate@chromium.org
Date: 2018-11-21 00:54:34 +0000 UTC

Chrome OS: Disable Pin Setup input field in incognito UI.

This Cl disables pin input field whan it is displayed in incognito UI.

TBR=alemate@chromium.org

(cherry picked from commit c3a9ed64df14e8143c6f1af0ac8fa1aa2db2253c)

Bug: 900351
Change-Id: I7aae9f08403933f12cae5345075e5e94e775e3a4
Reviewed-on: https://chromium-review.googlesource.com/c/1332929
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#607469}
Reviewed-on: https://chromium-review.googlesource.com/c/1345543
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#781}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 31 by bugdroid1@chromium.org, Nov 21

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd534b9d0010e2cee370022fe6e6982ef3357450

commit bd534b9d0010e2cee370022fe6e6982ef3357450
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Nov 21 00:54:34 2018

Chrome OS: Disable Pin Setup input field in incognito UI.

This Cl disables pin input field whan it is displayed in incognito UI.

TBR=alemate@chromium.org

(cherry picked from commit c3a9ed64df14e8143c6f1af0ac8fa1aa2db2253c)

Bug: 900351
Change-Id: I7aae9f08403933f12cae5345075e5e94e775e3a4
Reviewed-on: https://chromium-review.googlesource.com/c/1332929
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#607469}
Reviewed-on: https://chromium-review.googlesource.com/c/1345543
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#781}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/bd534b9d0010e2cee370022fe6e6982ef3357450/chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.html
[modify] https://crrev.com/bd534b9d0010e2cee370022fe6e6982ef3357450/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html
[modify] https://crrev.com/bd534b9d0010e2cee370022fe6e6982ef3357450/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.js
[modify] https://crrev.com/bd534b9d0010e2cee370022fe6e6982ef3357450/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.html
[modify] https://crrev.com/bd534b9d0010e2cee370022fe6e6982ef3357450/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.js

Labels: -Pri-1 Pri-2
Lower the pri as the issue has been mitigated by the fix by alemate@.

Sign in to add a comment