New issue
Advanced search Search tips

Issue 900325 link

Starred by 2 users
Status: Fixed
Owner:
timzheng@chromium.org
Closed: Nov 15
Cc:
jkardatzke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Fix color value arguments for demo apps in tests

Project Member Reported by jkardatzke@chromium.org, Oct 30 
I changed the x11_demo and wayland_demo to use the colors that we passed in as params in testing as the default values. I also changed how the parameters to those apps works so they use flags now rather than just expecting a single value.  The tast-test and the cros-tast-tests.deb files should be updated to use the new parameter style.

Nothing will break in the meantime because the default colors in the apps match what is in the tests.

Comment 1 by jkardatzke@chromium.org, Oct 30

Cc: jkardatzke@chromium.org
Owner: timzheng@chromium.org
Since you'll likely be making changes in all the same spots as what I'm referring to here...you can go ahead and do these.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/containers/cros-container-guest-tools/+/212f4e6ca2e5f6583a3c452b25b57122e1220156

commit 212f4e6ca2e5f6583a3c452b25b57122e1220156
Author: Tim Zheng <timzheng@google.com>
Date: Thu Nov 15 10:16:32 2018

cros-tast-tests: Update demo app color param pass.

This CL updates the demo apps desktop files to update way the color param
is passed in to the demo apps. They were passed in on the command line based on
position. This updates it to be passed in by its option name.

BUG= chromium:900325 
TEST=Buit the deb file and used it for tast run successfully.

Change-Id: I8b613d40b65e5e81de494315a9f159adbc27f572
Reviewed-on: https://chromium-review.googlesource.com/1327642
Commit-Ready: Tim Zheng <timzheng@chromium.org>
Tested-by: Tim Zheng <timzheng@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/212f4e6ca2e5f6583a3c452b25b57122e1220156/cros-tast-tests/wayland_demo.desktop
[modify] https://crrev.com/212f4e6ca2e5f6583a3c452b25b57122e1220156/cros-tast-tests/BUILD
[modify] https://crrev.com/212f4e6ca2e5f6583a3c452b25b57122e1220156/cros-tast-tests/x11_demo.desktop
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/b5f01c7ce10199e8ecf8c4599a52a22487dfaed6

commit b5f01c7ce10199e8ecf8c4599a52a22487dfaed6
Author: Tim Zheng <timzheng@google.com>
Date: Thu Nov 15 10:16:54 2018

Pass the color argument correctly to demo apps.

The way the color argument passed to the two demo apps have been
changed. This CL fixes the passing of the argument in tests.

BUG= chromium:900325 
TEST=tast run vm.CrostiniStartEverything

Change-Id: I443f6e60f87c0c523db135d62567c1affd390aa8
Reviewed-on: https://chromium-review.googlesource.com/1324777
Commit-Ready: Tim Zheng <timzheng@chromium.org>
Tested-by: Tim Zheng <timzheng@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>

[modify] https://crrev.com/b5f01c7ce10199e8ecf8c4599a52a22487dfaed6/src/chromiumos/tast/local/bundles/cros/vm/subtest/verify_app_from_terminal.go
[modify] https://crrev.com/b5f01c7ce10199e8ecf8c4599a52a22487dfaed6/src/chromiumos/tast/local/bundles/cros/vm/data/cros-tast-tests-deb.deb

Comment 4 by timzheng@chromium.org, Nov 15

Status: Fixed (was: Assigned)
►

Sign in to add a comment