[Findit] Flake Analyzer - Fallback to cq step metadata if not available on mapped wf build |
||
Issue descriptionSeveral analyses fail due to a breakage in LogDog causing step metadata not to be available, thus flake analysis would break as isolated_target_name is needed from it. For CI failures that require flake analysis, this is a non-issue as the step already made it that far to be identified as flaky. However for cq flakes, the mapped waterfall builder may have problems. Step metadata should be the same on both, so fallback to cq's in case the mapped waterfall builder's step metadata is unavailable.
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/28403ca64f4ce23fb7edcfd3111bc055fc672360 commit 28403ca64f4ce23fb7edcfd3111bc055fc672360 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Tue Oct 30 23:47:03 2018 [Findit] Flake Analyzer - Fallback to cq's step_metadata should mapped build's be unavailable An outage in LogDog can cause problems when attempting to get step_metadata. 1. If there is no outage, this change should have no effect. 2. Theoretically the step metadata for a cq step should be the same as that on the mapped waterfall builder's, so fall back to cq's step metadata. 3. CI failures should not need this fallback, since if the failure made it far enough to trigger flake analysis, then its step metadata should be available. Bug: 900322 Change-Id: I3bc0fc27b536d4a682fab325ff16a4773d51e352 Reviewed-on: https://chromium-review.googlesource.com/c/1308537 Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#18673} [modify] https://crrev.com/28403ca64f4ce23fb7edcfd3111bc055fc672360/appengine/findit/pipelines/flake_failure/analyze_recent_flakiness_pipeline.py [modify] https://crrev.com/28403ca64f4ce23fb7edcfd3111bc055fc672360/appengine/findit/waterfall/flake/initialize_flake_pipeline.py
,
Nov 1
|
||
►
Sign in to add a comment |
||
Comment 1 by lijeffrey@chromium.org
, Oct 30