Add "Warn Before Quitting" to settings |
||
Issue descriptionChrome Version: 72.0.3596.0 OS: macOS Issue 869185 turned "Warn Before Quitting" on by default. This option is currently only exposed in the Chrome menu in the menu bar, which might make it difficult for some users to find. This bug tracks adding it to Settings.
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8444fc2d83b4e44e2238ddd5adc25d7ecb1f9383 commit 8444fc2d83b4e44e2238ddd5adc25d7ecb1f9383 Author: Sidney San Martín <sdy@chromium.org> Date: Wed Oct 31 02:58:34 2018 [Mac] Add Warn Before Quitting to Settings. It's still in the Chrome menu, too. Bug: 900293 Change-Id: I86b7bab7ce9fb2f332f44f7a825544b7ca4eddd3 Reviewed-on: https://chromium-review.googlesource.com/c/1308760 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604127} [modify] https://crrev.com/8444fc2d83b4e44e2238ddd5adc25d7ecb1f9383/chrome/app/settings_strings.grdp [modify] https://crrev.com/8444fc2d83b4e44e2238ddd5adc25d7ecb1f9383/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/8444fc2d83b4e44e2238ddd5adc25d7ecb1f9383/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/8444fc2d83b4e44e2238ddd5adc25d7ecb1f9383/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Nov 15
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e330ef29b83ca8c8cfad6d155877b0315f56adec commit e330ef29b83ca8c8cfad6d155877b0315f56adec Author: Sidney San Martín <sdy@chromium.org> Date: Fri Nov 16 16:40:12 2018 Tweak wording to be consistent with nearby strings. Bug: 900293 Change-Id: Ibdb90ce9d2777311a1f67cd992f3ae326a9e1f01 Reviewed-on: https://chromium-review.googlesource.com/c/1338463 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#608807} [modify] https://crrev.com/e330ef29b83ca8c8cfad6d155877b0315f56adec/chrome/app/settings_strings.grdp
,
Nov 18
Hey sdy@, thanks for adding "Warn Before Quitting" to the Settings. Will the string in the Settings be translated into other language automatically by the Translation Team, or do we need a separate report for it? Just let me know, so that I can file it then. Thanks :) |
||
►
Sign in to add a comment |
||
Comment 1 by sdy@chromium.org
, Oct 30