Long app shortcut name truncated awkwardly |
|||||||||
Issue descriptionChrome Version: OS: ChromeOS What steps will reproduce the problem? (1) Set enable-app-shortcut-shortcut-search (2) Have GMail Android app installed, long tap on its icon in launcher or shelf, make sure that you see a shortcut with a specific email. If not, emailing someone (such as yourself) helps. (3) Search for that email in the launcher (4) Observe the GMail app shortcut in the search results What is the expected result? Long email is readable What happens instead? Email is truncated if it is long enough (see screenshot) Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Oct 30
Shiba, please advise how to best solve this. Ellipsized text? Tooltip? Both? Thanks!
,
Oct 31
Ellipsis makes sense here.
,
Oct 31
,
Oct 31
Specs from Sebastien: https://lh3.googleusercontent.com/-UdmBtpfVTkc/W9nvAOu5u4I/AAAAAAAAYuU/NjrHg9yxhWA7Eu_S0Q5fQpEobi0xVcCSQCL0BGAYYCw/h552/2018-10-31.png https://lh3.googleusercontent.com/-jztQSkR9-4s/W9nvOYeyR4I/AAAAAAAAYuY/sQmeKYlIeWMxt-E2E7MWDS0Pwu40TmK1wCL0BGAYYCw/h920/2018-10-31.png We should also break long names into two lines similar to app names.
,
Oct 31
,
Nov 1
,
Nov 1
The name will break if it contains spaces, the same as app names. I assume that most shortcut names will be relatively short words or phrases, and should fit into two lines with natural line breaks. However in this particular case the shortcut name is an email, and it can be quite long and there are no spaces. This is not likely to be a common case, but it will be there for GMail. It is very easy to allow mid-word line breaks (see attached screenshot), shall I do this?
,
Nov 9
Shiba, please advise
,
Dec 3
Bulk moving <p-1's to the next milestone because we branched to M-73.
,
Dec 20
,
Jan 2
Yes to Comment 8
,
Jan 4
,
Jan 8
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b740da684bad1c11a4ebcbb0fe9a6daaa317457 commit 1b740da684bad1c11a4ebcbb0fe9a6daaa317457 Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Tue Jan 08 22:10:51 2019 Allow mid-word breaks in long search result titles Bug: 900278 Test: manual, see bug Change-Id: Ic6b94576aae51743ef1399c22395e126505148de Reviewed-on: https://chromium-review.googlesource.com/c/1401069 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#620899} [modify] https://crrev.com/1b740da684bad1c11a4ebcbb0fe9a6daaa317457/ash/app_list/views/search_result_tile_item_view.cc
,
Jan 8
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by kaznacheev@chromium.org
, Oct 30172 KB
172 KB View Download