[📍] Cannot run pinpoint job |
||
Issue descriptionI've tried two ways to run a pinpoint job: - Via "Try job" button on the main page: https://pinpoint-dot-chromeperf.appspot.com/ - Via "Test a patch" button on a completed pinpoint job page: https://pinpoint-dot-chromeperf.appspot.com/job/12316ac3640000 In both cases I get the error: "invalid literal for int() with base 10: ''" after I click "START"
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/9662809abb166ca5fdf84fa640e4eccdb65b53d3 commit 9662809abb166ca5fdf84fa640e4eccdb65b53d3 Author: Dave Tu <dtu@chromium.org> Date: Tue Oct 30 20:14:31 2018 [pinpoint] Show full stack trace on invalid user input. This makes it easier to debug issues with user input handling. Make api_request_handler treat KeyError, TypeError, and ValueError as user errors. This is Pinpoint's convention. Bug: chromium:900275 Change-Id: I3b925f570966587b73beb758861ec223643bb8b7 Reviewed-on: https://chromium-review.googlesource.com/c/1308813 Auto-Submit: Dave Tu <dtu@chromium.org> Reviewed-by: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> [modify] https://crrev.com/9662809abb166ca5fdf84fa640e4eccdb65b53d3/dashboard/dashboard/api/api_request_handler.py [modify] https://crrev.com/9662809abb166ca5fdf84fa640e4eccdb65b53d3/dashboard/dashboard/pinpoint/handlers/new.py
,
Oct 30
I've found what I was doing wrong. The error appears if URL has a trailing slash. I was testing this URL: https://chromium-review.googlesource.com/c/chromium/src/+/1307445/ The job was created successfully after I removed the trailing slash: https://pinpoint-dot-chromeperf.appspot.com/job/10adfb79e40000
,
Oct 31
I believe this was fixed by sergiyb's change: https://crrev.com/c/1304594 I'll deploy Pinpoint now.
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40a7c2e537e256c73762f2c9522ca40a21826d22 commit 40a7c2e537e256c73762f2c9522ca40a21826d22 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Oct 31 03:17:11 2018 Roll src/third_party/catapult 5e1c1c293b07..9662809abb16 (3 commits) https://chromium.googlesource.com/catapult.git/+log/5e1c1c293b07..9662809abb16 git log 5e1c1c293b07..9662809abb16 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 dtu@chromium.org [pinpoint] Show full stack trace on invalid user input. 2018-10-30 achuith@chromium.org Disable sounds when running chromeos tests. 2018-10-30 ulan@chromium.org Fix summary options for the MMU metric histogram. Created with: gclient setdep -r src/third_party/catapult@9662809abb16 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:900275 TBR=sullivan@chromium.org Change-Id: Ieac3b98e597b7d9535a9aaa18e0f389eb6c73c23 Reviewed-on: https://chromium-review.googlesource.com/c/1309076 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604131} [modify] https://crrev.com/40a7c2e537e256c73762f2c9522ca40a21826d22/DEPS |
||
►
Sign in to add a comment |
||
Comment 1 by dtu@chromium.org
, Oct 30