New issue
Advanced search Search tips

Issue 900263 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Demo Mode session UMA stats

Project Member Reported by michae...@chromium.org, Oct 30

Issue description

We'd like to add the following UMA histograms for demo sessions:

P1 - DemoMode.IdleLogoutWarningResult: Whether the idle logout warning was cancelled or allowed to proceed

P2 - DemoMode.SessionEnd - How the demo session ended (e.g., ShelfExitButton, TrayExitButton, CloseAllWindows, IdleLogout)
 
Status: Started (was: Assigned)
We can add everything except for CloseAllWindows (it's already disabled in demo sessions).
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e91c7821d50ac78a8496cafb1d794ad6a5b56a3a

commit e91c7821d50ac78a8496cafb1d794ad6a5b56a3a
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Nov 07 23:35:14 2018

cros: Add idle logout warning UMA for demo mode

1. It's not easy to capture the "proceeded to logout" state because
   the logout is not initiated by Chrome. Also, it can't guarantee to
   be captured every time?

   Instead, we could record "shown" and "canceled", and in
   the comments emphasize that "show and proceeded" should be
   calculated by subtracting the two.

2. In |IdleActionWarningObserver::IdleActionImminent|, there's a check
   for if |warning_dialog_| already exists. I think this is a check
   for a rare case that the policy is updated while the dialog is
   showing. We should not record UMA in this case.

Bug:  900263 
Change-Id: Ied2f4b03252933e9ced3c792655e981b38105039
Reviewed-on: https://chromium-review.googlesource.com/c/1313118
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606208}
[modify] https://crrev.com/e91c7821d50ac78a8496cafb1d794ad6a5b56a3a/chrome/browser/chromeos/power/idle_action_warning_observer.cc
[modify] https://crrev.com/e91c7821d50ac78a8496cafb1d794ad6a5b56a3a/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/e91c7821d50ac78a8496cafb1d794ad6a5b56a3a/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b06aeeafb4536a7fbc49111e62e49d1a45af403e

commit b06aeeafb4536a7fbc49111e62e49d1a45af403e
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Nov 28 01:43:35 2018

cros: Add user action metrics for logout of demo sessions

Record metrics when user logs out the demo session by using the buttons
on shelf and system tray.

Bug:  900263 
Change-Id: I23ad6bf89b3b0e7a0edee265792cbffe8a9b9951
Reviewed-on: https://chromium-review.googlesource.com/c/1328231
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611499}
[modify] https://crrev.com/b06aeeafb4536a7fbc49111e62e49d1a45af403e/ash/session/test_session_controller_client.cc
[modify] https://crrev.com/b06aeeafb4536a7fbc49111e62e49d1a45af403e/ash/session/test_session_controller_client.h
[modify] https://crrev.com/b06aeeafb4536a7fbc49111e62e49d1a45af403e/ash/system/session/logout_button_tray.cc
[modify] https://crrev.com/b06aeeafb4536a7fbc49111e62e49d1a45af403e/ash/system/session/logout_button_tray.h
[modify] https://crrev.com/b06aeeafb4536a7fbc49111e62e49d1a45af403e/ash/system/session/logout_button_tray_unittest.cc
[modify] https://crrev.com/b06aeeafb4536a7fbc49111e62e49d1a45af403e/ash/system/session/logout_confirmation_controller.cc
[modify] https://crrev.com/b06aeeafb4536a7fbc49111e62e49d1a45af403e/ash/system/session/logout_confirmation_controller.h
[modify] https://crrev.com/b06aeeafb4536a7fbc49111e62e49d1a45af403e/ash/system/session/logout_confirmation_controller_unittest.cc
[modify] https://crrev.com/b06aeeafb4536a7fbc49111e62e49d1a45af403e/ash/system/unified/unified_system_tray_controller.cc
[modify] https://crrev.com/b06aeeafb4536a7fbc49111e62e49d1a45af403e/tools/metrics/actions/actions.xml

Status: Fixed (was: Started)

Sign in to add a comment