New issue
Advanced search Search tips

Issue 900244 link

Starred by 2 users
Status: Assigned
Owner:
k...@chromium.org
Cc:
jdonnelly@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

When UI direction doesn't match the language, focusing tab switch button homes cursor

Project Member Reported by k...@chromium.org, Oct 30 
Chrome Version: 72.0.3596.0
OS: Linux

What steps will reproduce the problem?
(1) Switch UI direction
(2) Generate a tab switch suggestion (open a URL in one tab, begin to enter it in another)
(3) Arrow to the tab switch button

What is the expected result?
That only the button would focus.

What happens instead?
The button focuses, but the cursor also homes (goes to the beginning of the Omnibox text.)
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/392fcdcbfef641404750d81a2263c379267e480e

commit 392fcdcbfef641404750d81a2263c379267e480e
Author: Kevin Bailey <krb@chromium.org>
Date: Fri Nov 02 21:02:24 2018

[omnibox] Fix arrow key behavior with Omnibox

This change includes 2 fixes:
 - When text and UI direction don't match, focusing the tab switch
button homes the cursor in the Omnibox. Now the cursor remains where
it is. (900244)
 - When there is autocomplete text and a tab switch button showing,
right arrow doesn't go to end. Now we check that the selection is
entirely at the end before consuming right arrow for the tab switch
button. (899597)

Bug:  899597 , 900244
Change-Id: Ib5c953d22c1b80f6f516a04d8e12e7d8b5b13c19
Reviewed-on: https://chromium-review.googlesource.com/c/1312983
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605048}
[modify] https://crrev.com/392fcdcbfef641404750d81a2263c379267e480e/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/392fcdcbfef641404750d81a2263c379267e480e/chrome/browser/ui/views/omnibox/omnibox_view_views.h
►

Sign in to add a comment